This repository has been archived by the owner on Apr 5, 2018. It is now read-only.
/
controller_test.go
307 lines (226 loc) · 9.11 KB
/
controller_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
package main
import (
"errors"
"net/http"
"net/http/httptest"
"os"
"strings"
"testing"
fthealth "github.com/Financial-Times/go-fthealth/v1a"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
type MockRegistry struct {
mock.Mock
}
func (r MockRegistry) categories() map[string]Category {
args := r.Called()
return args.Get(0).(map[string]Category)
}
func (r MockRegistry) matchingCategories(categories []string) []string {
args := r.Called(categories)
return args.Get(0).([]string)
}
func (r MockRegistry) areResilient(categories []string) bool {
args := r.Called(categories)
return args.Bool(0)
}
func (r MockRegistry) measuredServices() map[string]MeasuredService {
args := r.Called()
return args.Get(0).(map[string]MeasuredService)
}
func (r MockRegistry) checker() HealthChecker {
args := r.Called()
return args.Get(0).(HealthChecker)
}
func (r MockRegistry) getServiceAck(serviceKey string) string {
args := r.Called(serviceKey)
return args.String(0)
}
func (r MockRegistry) disableCategoryIfSticky(category string) {
r.Called(category)
}
func (r MockRegistry) updateCachedAndBufferedHealth(service *MeasuredService, result *fthealth.HealthResult) {
r.Called(service, result)
}
func (r MockRegistry) clusterAck() string {
return ""
}
type MockHealthChecker struct {
mock.Mock
}
func (c *MockHealthChecker) Check(service Service) (string, error) {
args := c.Called(service)
return args.String(0), args.Error(1)
}
func (c *MockHealthChecker) IsHighSeverity(service string) bool {
args := c.Called(service)
return args.Bool(0)
}
func (c *MockHealthChecker) FetchHealthcheck(service Service) (*healthcheckResponse, error) {
health := &healthcheckResponse{}
return health, nil
}
func mockCategories(r *MockRegistry, enabled []string, disabled []string) {
categories := make(map[string]Category)
for _, cat := range enabled {
categories[cat] = Category{Name: cat, Enabled: true}
}
for _, cat := range disabled {
categories[cat] = Category{Name: cat, Enabled: false}
}
r.On("categories").Return(categories)
}
func mockServices(r *MockRegistry, healthyServicesAndCategories map[string][]string, unhealthyServicesAndCategories map[string][]string) {
any := func(x interface{}) bool { return true }
c := new(MockHealthChecker)
c.On("IsHighSeverity", mock.MatchedBy(any)).Return(false)
r.On("checker").Return(c)
measuredServices := make(map[string]MeasuredService)
for service, categories := range healthyServicesAndCategories {
key := strings.ToLower(strings.Replace(service, " ", "-", -1))
s := Service{Name: service, ServiceKey: key, Categories: categories}
measuredService := MeasuredService{service: &s}
measuredServices[service] = measuredService
c.On("Check", s).Return("ok", nil)
}
for service, categories := range unhealthyServicesAndCategories {
key := strings.ToLower(strings.Replace(service, " ", "-", -1))
s := Service{Name: service, ServiceKey: key, Categories: categories}
measuredService := MeasuredService{service: &s}
measuredServices[service] = measuredService
c.On("Check", s).Return("nok", errors.New("Service "+service+" is unhealthy"))
}
r.On("measuredServices").Return(measuredServices)
r.On("getServiceAck", mock.MatchedBy(any)).Return("")
r.On("updateCachedAndBufferedHealth", mock.MatchedBy(any), mock.MatchedBy(any)).Return()
}
func TestCatEnabledWhenAllEnabled(t *testing.T) {
registry := new(MockRegistry)
mockCategories(registry, []string{"foo", "bar"}, []string{})
env := "test"
controller := NewController(registry, &env)
b := controller.catEnabled([]string{"foo", "bar"})
assert.True(t, b, "categories should be enabled")
}
func TestCatEnabledFalseWhenNotAllEnabled(t *testing.T) {
registry := new(MockRegistry)
mockCategories(registry, []string{"foo"}, []string{"bar"})
env := "test"
controller := NewController(registry, &env)
b := controller.catEnabled([]string{"foo", "bar"})
assert.False(t, b, "categories should not be enabled")
}
func TestCatEnabledWhenCategoryUnknown(t *testing.T) {
registry := new(MockRegistry)
mockCategories(registry, []string{"foo", "bar"}, []string{})
env := "test"
controller := NewController(registry, &env)
b := controller.catEnabled([]string{"foo", "bar", "baz"})
assert.True(t, b, "categories should be enabled")
}
func TestRunChecksFor(t *testing.T) {
registry := new(MockRegistry)
healthy := make(map[string][]string)
healthy["Test Service"] = []string{"foo"}
unhealthy := make(map[string][]string)
mockServices(registry, healthy, unhealthy)
env := "test"
controller := NewController(registry, &env)
results, categorisedResults := controller.runChecksFor([]string{"foo"})
assert.Len(t, results, 1, "results")
actual := results[0]
assert.True(t, actual.Ok, "service should be healthy")
assert.NotEqual(t, actual.Severity, 1, "service should not be high severity")
assert.Len(t, categorisedResults, 1, "categorised results")
assert.Len(t, categorisedResults["foo"], 1, "results in foo category")
assert.Equal(t, actual, categorisedResults["foo"][0], "categorised result")
}
func TestRunChecksForUnhealthy(t *testing.T) {
registry := new(MockRegistry)
healthy := make(map[string][]string)
unhealthy := make(map[string][]string)
unhealthy["Test Service"] = []string{"foo"}
mockServices(registry, healthy, unhealthy)
env := "test"
controller := NewController(registry, &env)
results, categorisedResults := controller.runChecksFor([]string{"foo"})
assert.Len(t, results, 1, "results")
actual := results[0]
assert.False(t, actual.Ok, "service should not be healthy")
assert.NotEqual(t, actual.Severity, 1, "service should not be high severity")
assert.Equal(t, "Service Test Service is unhealthy", actual.Output, "healthcheck output")
assert.Len(t, categorisedResults, 1, "categorised results")
assert.Len(t, categorisedResults["foo"], 1, "results in foo category")
assert.Equal(t, actual, categorisedResults["foo"][0], "categorised result")
}
func TestHandleGtgOk(t *testing.T) {
initLogs(os.Stdout, os.Stdout, os.Stderr)
any := func(x interface{}) bool { return true }
registry := new(MockRegistry)
healthy := make(map[string][]string)
healthy["Test Service"] = []string{"foo"}
unhealthy := make(map[string][]string)
mockServices(registry, healthy, unhealthy)
env := "test"
controller := NewController(registry, &env)
mockCategories(registry, []string{"foo"}, []string{})
registry.On("matchingCategories", []string{"foo"}).Return([]string{"Test Service"})
registry.On("areResilient", mock.MatchedBy(any)).Return(false)
req, _ := http.NewRequest("GET", "http://www.example.com/__gtg?categories=foo&cache=false", nil)
w := httptest.NewRecorder()
controller.handleGoodToGo(w, req)
assert.Equal(t, http.StatusOK, w.Code, "HTTP status")
registry.AssertExpectations(t)
}
func TestHandleGtgForDisabledCategory(t *testing.T) {
registry := new(MockRegistry)
mockCategories(registry, []string{"foo"}, []string{"bar"})
env := "test"
controller := NewController(registry, &env)
req, _ := http.NewRequest("GET", "http://www.example.com/__gtg?categories=bar", nil)
w := httptest.NewRecorder()
controller.handleGoodToGo(w, req)
assert.Equal(t, http.StatusServiceUnavailable, w.Code, "HTTP status")
}
func TestHandleGtgUnhealthySetsDisabledIfSticky(t *testing.T) {
initLogs(os.Stdout, os.Stdout, os.Stderr)
any := func(x interface{}) bool { return true }
registry := new(MockRegistry)
healthy := make(map[string][]string)
unhealthy := make(map[string][]string)
unhealthy["Test Service"] = []string{"foo"}
mockServices(registry, healthy, unhealthy)
env := "test"
controller := NewController(registry, &env)
mockCategories(registry, []string{"foo"}, []string{})
registry.On("matchingCategories", []string{"foo"}).Return([]string{"Test Service"})
registry.On("areResilient", mock.MatchedBy(any)).Return(false)
registry.On("disableCategoryIfSticky", "foo").Return()
req, _ := http.NewRequest("GET", "http://www.example.com/__gtg?categories=foo&cache=false", nil)
w := httptest.NewRecorder()
controller.handleGoodToGo(w, req)
assert.Equal(t, http.StatusServiceUnavailable, w.Code, "HTTP status")
registry.AssertExpectations(t)
}
func TestHandleGtgUnhealthySetsUnhealthyCategoriesOnlyDisabled(t *testing.T) {
initLogs(os.Stdout, os.Stdout, os.Stderr)
any := func(x interface{}) bool { return true }
registry := new(MockRegistry)
healthy := make(map[string][]string)
healthy["Test Service 1"] = []string{"foo"}
unhealthy := make(map[string][]string)
unhealthy["Test Service 2"] = []string{"bar"}
mockServices(registry, healthy, unhealthy)
env := "test"
controller := NewController(registry, &env)
mockCategories(registry, []string{"foo", "bar"}, []string{})
registry.On("matchingCategories", []string{"foo", "bar"}).Return([]string{"Test Service 1", "Test Service 2"})
registry.On("areResilient", mock.MatchedBy(any)).Return(false)
registry.On("disableCategoryIfSticky", "bar").Return() // only expect to be called for category "bar"
req, _ := http.NewRequest("GET", "http://www.example.com/__gtg?categories=foo,bar&cache=false", nil)
w := httptest.NewRecorder()
controller.handleGoodToGo(w, req)
assert.Equal(t, http.StatusServiceUnavailable, w.Code, "HTTP status")
registry.AssertExpectations(t)
}