forked from cloudfoundry-attic/bosh-init
/
manager_test.go
363 lines (283 loc) · 13.3 KB
/
manager_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
package deployment_test
import (
. "github.com/cloudfoundry/bosh-init/deployment"
mock_blobstore "github.com/cloudfoundry/bosh-init/blobstore/mocks"
mock_cloud "github.com/cloudfoundry/bosh-init/cloud/mocks"
mock_disk "github.com/cloudfoundry/bosh-init/deployment/disk/mocks"
mock_instance "github.com/cloudfoundry/bosh-init/deployment/instance/mocks"
mock_instance_state "github.com/cloudfoundry/bosh-init/deployment/instance/state/mocks"
mock_deployment "github.com/cloudfoundry/bosh-init/deployment/mocks"
mock_agentclient "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-agent/agentclient/mocks"
"github.com/cloudfoundry/bosh-init/internal/github.com/golang/mock/gomock"
. "github.com/cloudfoundry/bosh-init/internal/github.com/onsi/ginkgo"
. "github.com/cloudfoundry/bosh-init/internal/github.com/onsi/gomega"
mock_stemcell "github.com/cloudfoundry/bosh-init/stemcell/mocks"
bicloud "github.com/cloudfoundry/bosh-init/cloud"
biconfig "github.com/cloudfoundry/bosh-init/config"
bidisk "github.com/cloudfoundry/bosh-init/deployment/disk"
biinstance "github.com/cloudfoundry/bosh-init/deployment/instance"
bisshtunnel "github.com/cloudfoundry/bosh-init/deployment/sshtunnel"
bivm "github.com/cloudfoundry/bosh-init/deployment/vm"
boshlog "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/logger"
boshsys "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/system"
fakesys "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/system/fakes"
fakeuuid "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/uuid/fakes"
bistemcell "github.com/cloudfoundry/bosh-init/stemcell"
fakebiui "github.com/cloudfoundry/bosh-init/ui/fakes"
)
var _ = Describe("Manager", func() {
var mockCtrl *gomock.Controller
BeforeEach(func() {
mockCtrl = gomock.NewController(GinkgoT())
})
AfterEach(func() {
mockCtrl.Finish()
})
Describe("FindCurrent", func() {
var (
mockInstanceManager *mock_instance.MockManager
mockDiskManager *mock_disk.MockManager
mockStemcellManager *mock_stemcell.MockManager
mockDeploymentFactory *mock_deployment.MockFactory
mockDeployment *mock_deployment.MockDeployment
deploymentManager Manager
expectedInstances []biinstance.Instance
expectedDisks []bidisk.Disk
expectedStemcells []bistemcell.CloudStemcell
expectNewDeployment *gomock.Call
)
BeforeEach(func() {
mockInstanceManager = mock_instance.NewMockManager(mockCtrl)
mockDiskManager = mock_disk.NewMockManager(mockCtrl)
mockStemcellManager = mock_stemcell.NewMockManager(mockCtrl)
mockDeploymentFactory = mock_deployment.NewMockFactory(mockCtrl)
mockDeployment = mock_deployment.NewMockDeployment(mockCtrl)
expectedInstances = []biinstance.Instance{}
expectedDisks = []bidisk.Disk{}
expectedStemcells = []bistemcell.CloudStemcell{}
})
JustBeforeEach(func() {
mockInstanceManager.EXPECT().FindCurrent().Return(expectedInstances, nil)
mockDiskManager.EXPECT().FindCurrent().Return(expectedDisks, nil)
mockStemcellManager.EXPECT().FindCurrent().Return(expectedStemcells, nil)
expectNewDeployment = mockDeploymentFactory.EXPECT().NewDeployment(expectedInstances, expectedDisks, expectedStemcells).Return(mockDeployment).AnyTimes()
deploymentManager = NewManager(mockInstanceManager, mockDiskManager, mockStemcellManager, mockDeploymentFactory)
})
Context("when no current instances, disks, or stemcells exist", func() {
It("returns not found", func() {
_, found, err := deploymentManager.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeFalse())
})
})
Context("when current instances exist", func() {
BeforeEach(func() {
instance := mock_instance.NewMockInstance(mockCtrl)
expectedInstances = append(expectedInstances, instance)
})
It("returns a deployment that wraps the current instances, disks, & stemcells", func() {
expectNewDeployment.Times(1)
deployment, found, err := deploymentManager.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeTrue())
Expect(deployment).To(Equal(mockDeployment))
})
})
Context("when current disk exist", func() {
BeforeEach(func() {
disk := mock_disk.NewMockDisk(mockCtrl)
expectedDisks = append(expectedDisks, disk)
})
It("returns a deployment that wraps the current instances, disks, & stemcells", func() {
expectNewDeployment.Times(1)
deployment, found, err := deploymentManager.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeTrue())
Expect(deployment).To(Equal(mockDeployment))
})
})
Context("when current stemcell exist", func() {
BeforeEach(func() {
stemcell := mock_stemcell.NewMockCloudStemcell(mockCtrl)
expectedStemcells = append(expectedStemcells, stemcell)
})
It("returns a deployment that wraps the current instances, disks, & stemcells", func() {
expectNewDeployment.Times(1)
deployment, found, err := deploymentManager.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeTrue())
Expect(deployment).To(Equal(mockDeployment))
})
})
})
Describe("Cleanup", func() {
var (
logger boshlog.Logger
fs boshsys.FileSystem
mockDeploymentFactory *mock_deployment.MockFactory
mockStateBuilderFactory *mock_instance_state.MockBuilderFactory
mockBlobstore *mock_blobstore.MockBlobstore
fakeUUIDGenerator *fakeuuid.FakeGenerator
fakeRepoUUIDGenerator *fakeuuid.FakeGenerator
deploymentStateService biconfig.DeploymentStateService
vmRepo biconfig.VMRepo
diskRepo biconfig.DiskRepo
stemcellRepo biconfig.StemcellRepo
mockCloud *mock_cloud.MockCloud
mockAgentClient *mock_agentclient.MockAgentClient
fakeStage *fakebiui.FakeStage
deploymentManager Manager
)
BeforeEach(func() {
logger = boshlog.NewLogger(boshlog.LevelNone)
fs = fakesys.NewFakeFileSystem()
mockDeploymentFactory = mock_deployment.NewMockFactory(mockCtrl)
fakeUUIDGenerator = fakeuuid.NewFakeGenerator()
deploymentStateService = biconfig.NewFileSystemDeploymentStateService(fs, fakeUUIDGenerator, logger, "/deployment.json")
fakeRepoUUIDGenerator = fakeuuid.NewFakeGenerator()
vmRepo = biconfig.NewVMRepo(deploymentStateService)
diskRepo = biconfig.NewDiskRepo(deploymentStateService, fakeRepoUUIDGenerator)
stemcellRepo = biconfig.NewStemcellRepo(deploymentStateService, fakeRepoUUIDGenerator)
mockCloud = mock_cloud.NewMockCloud(mockCtrl)
mockAgentClient = mock_agentclient.NewMockAgentClient(mockCtrl)
fakeStage = fakebiui.NewFakeStage()
})
JustBeforeEach(func() {
diskManagerFactory := bidisk.NewManagerFactory(diskRepo, logger)
diskDeployer := bivm.NewDiskDeployer(diskManagerFactory, diskRepo, logger)
vmManagerFactory := bivm.NewManagerFactory(vmRepo, stemcellRepo, diskDeployer, fakeUUIDGenerator, fs, logger)
sshTunnelFactory := bisshtunnel.NewFactory(logger)
mockStateBuilderFactory = mock_instance_state.NewMockBuilderFactory(mockCtrl)
instanceFactory := biinstance.NewFactory(mockStateBuilderFactory)
instanceManagerFactory := biinstance.NewManagerFactory(sshTunnelFactory, instanceFactory, logger)
stemcellManagerFactory := bistemcell.NewManagerFactory(stemcellRepo)
mockBlobstore = mock_blobstore.NewMockBlobstore(mockCtrl)
deploymentManagerFactory := NewManagerFactory(vmManagerFactory, instanceManagerFactory, diskManagerFactory, stemcellManagerFactory, mockDeploymentFactory)
deploymentManager = deploymentManagerFactory.NewManager(mockCloud, mockAgentClient, mockBlobstore)
})
Context("no orphan disk or stemcell records exist", func() {
var (
currentDiskRecord biconfig.DiskRecord
currentStemcellRecord biconfig.StemcellRecord
)
BeforeEach(func() {
var err error
currentDiskRecord, err = diskRepo.Save("fake-disk-cid", 100, nil)
Expect(err).ToNot(HaveOccurred())
err = diskRepo.UpdateCurrent(currentDiskRecord.ID)
Expect(err).ToNot(HaveOccurred())
currentStemcellRecord, err = stemcellRepo.Save("fake-stemcell-name", "fake-stemcell-version", "fake-stemcell-cid")
Expect(err).ToNot(HaveOccurred())
err = stemcellRepo.UpdateCurrent(currentStemcellRecord.ID)
Expect(err).ToNot(HaveOccurred())
})
It("does not delete anything", func() {
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
diskRecord, found, err := diskRepo.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeTrue())
Expect(diskRecord).To(Equal(currentDiskRecord))
stemcellRecord, found, err := stemcellRepo.FindCurrent()
Expect(err).ToNot(HaveOccurred())
Expect(found).To(BeTrue())
Expect(stemcellRecord).To(Equal(currentStemcellRecord))
})
It("does not log any stages", func() {
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
Expect(fakeStage.PerformCalls).To(BeEmpty())
})
})
Context("orphan disk records exist", func() {
BeforeEach(func() {
_, err := diskRepo.Save("orphan-disk-cid", 100, nil)
Expect(err).ToNot(HaveOccurred())
})
It("deletes the unused disks", func() {
mockCloud.EXPECT().DeleteDisk("orphan-disk-cid")
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
diskRecords, err := diskRepo.All()
Expect(err).ToNot(HaveOccurred())
Expect(diskRecords).To(BeEmpty(), "expected no disk records")
})
It("logs delete stage", func() {
mockCloud.EXPECT().DeleteDisk("orphan-disk-cid")
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
Expect(fakeStage.PerformCalls).To(ContainElement(&fakebiui.PerformCall{
Name: "Deleting unused disk 'orphan-disk-cid'",
}))
})
Context("when disks have been deleted manually (in the infrastructure)", func() {
It("deletes the unused disks, ignoring DiskNotFoundError", func() {
mockCloud.EXPECT().DeleteDisk("orphan-disk-cid").Return(bicloud.NewCPIError("delete_disk", bicloud.CmdError{
Type: bicloud.DiskNotFoundError,
Message: "fake-disk-not-found-message",
}))
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
diskRecords, err := diskRepo.All()
Expect(err).ToNot(HaveOccurred())
Expect(diskRecords).To(BeEmpty(), "expected no disk records")
})
It("logs disk deletion as skipped", func() {
mockCloud.EXPECT().DeleteDisk("orphan-disk-cid").Return(bicloud.NewCPIError("delete_disk", bicloud.CmdError{
Type: bicloud.DiskNotFoundError,
Message: "fake-disk-not-found-message",
}))
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
Expect(fakeStage.PerformCalls[0].Name).To(Equal("Deleting unused disk 'orphan-disk-cid'"))
Expect(fakeStage.PerformCalls[0].SkipError.Error()).To(Equal("Disk Not Found: CPI 'delete_disk' method responded with error: CmdError{\"type\":\"Bosh::Clouds::DiskNotFound\",\"message\":\"fake-disk-not-found-message\",\"ok_to_retry\":false}"))
})
})
})
Context("orphan stemcell records exist", func() {
BeforeEach(func() {
_, err := stemcellRepo.Save("orphan-stemcell-name", "orphan-stemcell-version", "orphan-stemcell-cid")
Expect(err).ToNot(HaveOccurred())
})
It("deletes the unused stemcells", func() {
mockCloud.EXPECT().DeleteStemcell("orphan-stemcell-cid")
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
stemcellRecords, err := stemcellRepo.All()
Expect(err).ToNot(HaveOccurred())
Expect(stemcellRecords).To(BeEmpty(), "expected no stemcell records")
})
It("logs delete stage", func() {
mockCloud.EXPECT().DeleteStemcell("orphan-stemcell-cid")
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
Expect(fakeStage.PerformCalls).To(ContainElement(&fakebiui.PerformCall{
Name: "Deleting unused stemcell 'orphan-stemcell-cid'",
}))
})
Context("when stemcells have been deleted manually (in the infrastructure)", func() {
It("deletes the unused stemcells, ignoring StemcellNotFoundError", func() {
mockCloud.EXPECT().DeleteStemcell("orphan-stemcell-cid").Return(bicloud.NewCPIError("delete_stemcell", bicloud.CmdError{
Type: bicloud.StemcellNotFoundError,
Message: "fake-stemcell-not-found-message",
}))
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
stemcellRecords, err := diskRepo.All()
Expect(err).ToNot(HaveOccurred())
Expect(stemcellRecords).To(BeEmpty(), "expected no stemcell records")
})
It("logs stemcell deletion as skipped", func() {
mockCloud.EXPECT().DeleteStemcell("orphan-stemcell-cid").Return(bicloud.NewCPIError("delete_stemcell", bicloud.CmdError{
Type: bicloud.StemcellNotFoundError,
Message: "fake-stemcell-not-found-message",
}))
err := deploymentManager.Cleanup(fakeStage)
Expect(err).ToNot(HaveOccurred())
Expect(fakeStage.PerformCalls[0].Name).To(Equal("Deleting unused stemcell 'orphan-stemcell-cid'"))
Expect(fakeStage.PerformCalls[0].SkipError.Error()).To(Equal("Stemcell not found: CPI 'delete_stemcell' method responded with error: CmdError{\"type\":\"Bosh::Clouds::StemcellNotFound\",\"message\":\"fake-stemcell-not-found-message\",\"ok_to_retry\":false}"))
})
})
})
})
})