func (a *buildOverrides) applyOverrides(attributes admission.Attributes) error {
if !a.overridesConfig.ForcePull {
return nil
}
build, version, err := buildadmission.GetBuild(attributes)
if err != nil {
return err
}
glog.V(4).Infof("Handling build %s/%s", build.Namespace, build.Name)
if build.Spec.Strategy.DockerStrategy != nil {
glog.V(5).Infof("Setting docker strategy ForcePull to true in build %s/%s", build.Namespace, build.Name)
build.Spec.Strategy.DockerStrategy.ForcePull = true
}
if build.Spec.Strategy.SourceStrategy != nil {
glog.V(5).Infof("Setting source strategy ForcePull to true in build %s/%s", build.Namespace, build.Name)
build.Spec.Strategy.SourceStrategy.ForcePull = true
}
if build.Spec.Strategy.CustomStrategy != nil {
err := applyForcePullToPod(attributes)
if err != nil {
return err
}
glog.V(5).Infof("Setting custom strategy ForcePull to true in build %s/%s", build.Namespace, build.Name)
build.Spec.Strategy.CustomStrategy.ForcePull = true
}
return buildadmission.SetBuild(attributes, build, version)
}
func TestProxyDefaults(t *testing.T) {
defaultsConfig := &defaultsapi.BuildDefaultsConfig{
GitHTTPProxy: "http",
GitHTTPSProxy: "https",
GitNoProxy: "no",
}
admitter := NewBuildDefaults(defaultsConfig)
pod := u.Pod().WithBuild(t, u.Build().WithDockerStrategy().AsBuild(), "v1")
err := admitter.Admit(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
build, _, err := buildadmission.GetBuild(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if build.Spec.Source.Git.HTTPProxy == nil || len(*build.Spec.Source.Git.HTTPProxy) == 0 || *build.Spec.Source.Git.HTTPProxy != "http" {
t.Errorf("failed to find http proxy in git source")
}
if build.Spec.Source.Git.HTTPSProxy == nil || len(*build.Spec.Source.Git.HTTPSProxy) == 0 || *build.Spec.Source.Git.HTTPSProxy != "https" {
t.Errorf("failed to find http proxy in git source")
}
if build.Spec.Source.Git.NoProxy == nil || len(*build.Spec.Source.Git.NoProxy) == 0 || *build.Spec.Source.Git.NoProxy != "no" {
t.Errorf("failed to find no proxy setting in git source")
}
}
func TestIncrementalDefaults(t *testing.T) {
bool_t := true
defaultsConfig := &defaultsapi.BuildDefaultsConfig{
SourceStrategyDefaults: &defaultsapi.SourceStrategyDefaultsConfig{
Incremental: &bool_t,
},
}
admitter := NewBuildDefaults(defaultsConfig)
pod := u.Pod().WithBuild(t, u.Build().WithSourceStrategy().AsBuild(), "v1")
err := admitter.Admit(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
build, _, err := buildadmission.GetBuild(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !*build.Spec.Strategy.SourceStrategy.Incremental {
t.Errorf("failed to default incremental to true")
}
build = u.Build().WithSourceStrategy().AsBuild()
bool_f := false
build.Spec.Strategy.SourceStrategy.Incremental = &bool_f
pod = u.Pod().WithBuild(t, build, "v1")
err = admitter.Admit(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
build, _, err = buildadmission.GetBuild(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if *build.Spec.Strategy.SourceStrategy.Incremental {
t.Errorf("should not have overridden incremental to true")
}
}
func TestEnvDefaults(t *testing.T) {
defaultsConfig := &defaultsapi.BuildDefaultsConfig{
Env: []kapi.EnvVar{
{
Name: "VAR1",
Value: "VALUE1",
},
{
Name: "VAR2",
Value: "VALUE2",
},
},
}
admitter := NewBuildDefaults(defaultsConfig)
pod := u.Pod().WithBuild(t, u.Build().WithSourceStrategy().AsBuild(), "v1")
err := admitter.Admit(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
build, _, err := buildadmission.GetBuild(pod.ToAttributes())
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
env := getBuildEnv(build)
var1found, var2found := false, false
for _, ev := range *env {
if ev.Name == "VAR1" {
if ev.Value != "VALUE1" {
t.Errorf("unexpected value %s", ev.Value)
}
var1found = true
}
if ev.Name == "VAR2" {
if ev.Value != "VALUE2" {
t.Errorf("unexpected value %s", ev.Value)
}
var2found = true
}
}
if !var1found {
t.Errorf("VAR1 not found")
}
if !var2found {
t.Errorf("VAR2 not found")
}
}
// Admit applies configured build defaults to a pod that is identified
// as a build pod.
func (a *buildDefaults) Admit(attributes admission.Attributes) error {
if a.defaultsConfig == nil {
return nil
}
if !buildadmission.IsBuildPod(attributes) {
return nil
}
build, version, err := buildadmission.GetBuild(attributes)
if err != nil {
return nil
}
glog.V(4).Infof("Handling build %s/%s", build.Namespace, build.Name)
a.applyBuildDefaults(build)
return buildadmission.SetBuild(attributes, build, version)
}
func (a *buildOverrides) applyOverrides(attributes admission.Attributes) error {
build, version, err := buildadmission.GetBuild(attributes)
if err != nil {
return err
}
glog.V(4).Infof("Handling build %s/%s", build.Namespace, build.Name)
if a.overridesConfig.ForcePull {
if err := applyForcePullToBuild(build, attributes); err != nil {
return err
}
}
// Apply label overrides
for _, lbl := range a.overridesConfig.ImageLabels {
glog.V(5).Infof("Overriding image label %s=%s in build %s/%s", lbl.Name, lbl.Value, build.Namespace, build.Name)
overrideLabel(lbl, &build.Spec.Output.ImageLabels)
}
return buildadmission.SetBuild(attributes, build, version)
}
