forked from juju/charm
/
bundle_test.go
345 lines (288 loc) · 9.71 KB
/
bundle_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
// Copyright 2011, 2012, 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package charm_test
import (
"archive/zip"
"bytes"
"fmt"
"io/ioutil"
"os"
"os/exec"
"path/filepath"
"strconv"
"syscall"
"github.com/juju/charm"
charmtesting "github.com/juju/charm/testing"
jc "github.com/juju/testing/checkers"
"github.com/juju/utils/set"
gc "launchpad.net/gocheck"
"launchpad.net/goyaml"
)
type BundleSuite struct {
repo *charmtesting.Repo
bundlePath string
}
var _ = gc.Suite(&BundleSuite{})
func (s *BundleSuite) SetUpSuite(c *gc.C) {
s.bundlePath = charmtesting.Charms.BundlePath(c.MkDir(), "dummy")
}
var dummyManifest = []string{
"actions.yaml",
"config.yaml",
"empty",
"empty/.gitkeep",
"hooks",
"hooks/install",
"metadata.yaml",
"revision",
"src",
"src/hello.c",
}
func (s *BundleSuite) TestReadBundle(c *gc.C) {
bundle, err := charm.ReadBundle(s.bundlePath)
c.Assert(err, gc.IsNil)
checkDummy(c, bundle, s.bundlePath)
}
func (s *BundleSuite) TestReadBundleWithoutConfig(c *gc.C) {
// Technically varnish has no config AND no actions.
// Perhaps we should make this more orthogonal?
path := charmtesting.Charms.BundlePath(c.MkDir(), "varnish")
bundle, err := charm.ReadBundle(path)
c.Assert(err, gc.IsNil)
// A lacking config.yaml file still causes a proper
// Config value to be returned.
c.Assert(bundle.Config().Options, gc.HasLen, 0)
}
func (s *BundleSuite) TestReadBundleWithoutActions(c *gc.C) {
// Wordpress has config but no actions.
path := charmtesting.Charms.BundlePath(c.MkDir(), "wordpress")
bundle, err := charm.ReadBundle(path)
c.Assert(err, gc.IsNil)
// A lacking actions.yaml file still causes a proper
// Actions value to be returned.
c.Assert(bundle.Actions().ActionSpecs, gc.HasLen, 0)
}
func (s *BundleSuite) TestReadBundleBytes(c *gc.C) {
data, err := ioutil.ReadFile(s.bundlePath)
c.Assert(err, gc.IsNil)
bundle, err := charm.ReadBundleBytes(data)
c.Assert(err, gc.IsNil)
checkDummy(c, bundle, "")
}
func (s *BundleSuite) TestManifest(c *gc.C) {
bundle, err := charm.ReadBundle(s.bundlePath)
c.Assert(err, gc.IsNil)
manifest, err := bundle.Manifest()
c.Assert(err, gc.IsNil)
c.Assert(manifest, jc.DeepEquals, set.NewStrings(dummyManifest...))
}
func (s *BundleSuite) TestManifestNoRevision(c *gc.C) {
bundle, err := charm.ReadBundle(s.bundlePath)
c.Assert(err, gc.IsNil)
dirPath := c.MkDir()
err = bundle.ExpandTo(dirPath)
c.Assert(err, gc.IsNil)
err = os.Remove(filepath.Join(dirPath, "revision"))
c.Assert(err, gc.IsNil)
bundle = extBundleDir(c, dirPath)
manifest, err := bundle.Manifest()
c.Assert(err, gc.IsNil)
c.Assert(manifest, gc.DeepEquals, set.NewStrings(dummyManifest...))
}
func (s *BundleSuite) TestManifestSymlink(c *gc.C) {
srcPath := charmtesting.Charms.ClonedDirPath(c.MkDir(), "dummy")
if err := os.Symlink("../target", filepath.Join(srcPath, "hooks/symlink")); err != nil {
c.Skip("cannot symlink")
}
expected := append([]string{"hooks/symlink"}, dummyManifest...)
bundle := bundleDir(c, srcPath)
manifest, err := bundle.Manifest()
c.Assert(err, gc.IsNil)
c.Assert(manifest, gc.DeepEquals, set.NewStrings(expected...))
}
func (s *BundleSuite) TestExpandTo(c *gc.C) {
bundle, err := charm.ReadBundle(s.bundlePath)
c.Assert(err, gc.IsNil)
path := filepath.Join(c.MkDir(), "charm")
err = bundle.ExpandTo(path)
c.Assert(err, gc.IsNil)
dir, err := charm.ReadDir(path)
c.Assert(err, gc.IsNil)
checkDummy(c, dir, path)
}
func (s *BundleSuite) prepareBundle(c *gc.C, charmDir *charm.Dir, bundlePath string) {
file, err := os.Create(bundlePath)
c.Assert(err, gc.IsNil)
defer file.Close()
zipw := zip.NewWriter(file)
defer zipw.Close()
h := &zip.FileHeader{Name: "revision"}
h.SetMode(syscall.S_IFREG | 0644)
w, err := zipw.CreateHeader(h)
c.Assert(err, gc.IsNil)
_, err = w.Write([]byte(strconv.Itoa(charmDir.Revision())))
h = &zip.FileHeader{Name: "metadata.yaml", Method: zip.Deflate}
h.SetMode(0644)
w, err = zipw.CreateHeader(h)
c.Assert(err, gc.IsNil)
data, err := goyaml.Marshal(charmDir.Meta())
c.Assert(err, gc.IsNil)
_, err = w.Write(data)
c.Assert(err, gc.IsNil)
for name := range charmDir.Meta().Hooks() {
hookName := filepath.Join("hooks", name)
h = &zip.FileHeader{
Name: hookName,
Method: zip.Deflate,
}
// Force it non-executable
h.SetMode(0644)
w, err := zipw.CreateHeader(h)
c.Assert(err, gc.IsNil)
_, err = w.Write([]byte("not important"))
c.Assert(err, gc.IsNil)
}
}
func (s *BundleSuite) TestExpandToSetsHooksExecutable(c *gc.C) {
charmDir := charmtesting.Charms.ClonedDir(c.MkDir(), "all-hooks")
// Bundle manually, so we can check ExpandTo(), unaffected
// by BundleTo()'s behavior
bundlePath := filepath.Join(c.MkDir(), "bundle.charm")
s.prepareBundle(c, charmDir, bundlePath)
bundle, err := charm.ReadBundle(bundlePath)
c.Assert(err, gc.IsNil)
path := filepath.Join(c.MkDir(), "charm")
err = bundle.ExpandTo(path)
c.Assert(err, gc.IsNil)
_, err = charm.ReadDir(path)
c.Assert(err, gc.IsNil)
for name := range bundle.Meta().Hooks() {
hookName := string(name)
info, err := os.Stat(filepath.Join(path, "hooks", hookName))
c.Assert(err, gc.IsNil)
perm := info.Mode() & 0777
c.Assert(perm&0100 != 0, gc.Equals, true, gc.Commentf("hook %q is not executable", hookName))
}
}
func (s *BundleSuite) TestBundleFileModes(c *gc.C) {
// Apply subtler mode differences than can be expressed in Bazaar.
srcPath := charmtesting.Charms.ClonedDirPath(c.MkDir(), "dummy")
modes := []struct {
path string
mode os.FileMode
}{
{"hooks/install", 0751},
{"empty", 0750},
{"src/hello.c", 0614},
}
for _, m := range modes {
err := os.Chmod(filepath.Join(srcPath, m.path), m.mode)
c.Assert(err, gc.IsNil)
}
var haveSymlinks = true
if err := os.Symlink("../target", filepath.Join(srcPath, "hooks/symlink")); err != nil {
haveSymlinks = false
}
// Bundle and extract the charm to a new directory.
bundle := bundleDir(c, srcPath)
path := c.MkDir()
err := bundle.ExpandTo(path)
c.Assert(err, gc.IsNil)
// Check sensible file modes once round-tripped.
info, err := os.Stat(filepath.Join(path, "src", "hello.c"))
c.Assert(err, gc.IsNil)
c.Assert(info.Mode()&0777, gc.Equals, os.FileMode(0644))
c.Assert(info.Mode()&os.ModeType, gc.Equals, os.FileMode(0))
info, err = os.Stat(filepath.Join(path, "hooks", "install"))
c.Assert(err, gc.IsNil)
c.Assert(info.Mode()&0777, gc.Equals, os.FileMode(0755))
c.Assert(info.Mode()&os.ModeType, gc.Equals, os.FileMode(0))
info, err = os.Stat(filepath.Join(path, "empty"))
c.Assert(err, gc.IsNil)
c.Assert(info.Mode()&0777, gc.Equals, os.FileMode(0755))
if haveSymlinks {
target, err := os.Readlink(filepath.Join(path, "hooks", "symlink"))
c.Assert(err, gc.IsNil)
c.Assert(target, gc.Equals, "../target")
}
}
func (s *BundleSuite) TestBundleRevisionFile(c *gc.C) {
charmDir := charmtesting.Charms.ClonedDirPath(c.MkDir(), "dummy")
revPath := filepath.Join(charmDir, "revision")
// Missing revision file
err := os.Remove(revPath)
c.Assert(err, gc.IsNil)
bundle := extBundleDir(c, charmDir)
c.Assert(bundle.Revision(), gc.Equals, 0)
// Missing revision file with old revision in metadata
file, err := os.OpenFile(filepath.Join(charmDir, "metadata.yaml"), os.O_WRONLY|os.O_APPEND, 0)
c.Assert(err, gc.IsNil)
_, err = file.Write([]byte("\nrevision: 1234\n"))
c.Assert(err, gc.IsNil)
bundle = extBundleDir(c, charmDir)
c.Assert(bundle.Revision(), gc.Equals, 1234)
// Revision file with bad content
err = ioutil.WriteFile(revPath, []byte("garbage"), 0666)
c.Assert(err, gc.IsNil)
path := extBundleDirPath(c, charmDir)
bundle, err = charm.ReadBundle(path)
c.Assert(err, gc.ErrorMatches, "invalid revision file")
c.Assert(bundle, gc.IsNil)
}
func (s *BundleSuite) TestBundleSetRevision(c *gc.C) {
bundle, err := charm.ReadBundle(s.bundlePath)
c.Assert(err, gc.IsNil)
c.Assert(bundle.Revision(), gc.Equals, 1)
bundle.SetRevision(42)
c.Assert(bundle.Revision(), gc.Equals, 42)
path := filepath.Join(c.MkDir(), "charm")
err = bundle.ExpandTo(path)
c.Assert(err, gc.IsNil)
dir, err := charm.ReadDir(path)
c.Assert(err, gc.IsNil)
c.Assert(dir.Revision(), gc.Equals, 42)
}
func (s *BundleSuite) TestExpandToWithBadLink(c *gc.C) {
charmDir := charmtesting.Charms.ClonedDirPath(c.MkDir(), "dummy")
badLink := filepath.Join(charmDir, "hooks", "badlink")
// Symlink targeting a path outside of the charm.
err := os.Symlink("../../target", badLink)
c.Assert(err, gc.IsNil)
bundle := extBundleDir(c, charmDir)
c.Assert(err, gc.IsNil)
path := filepath.Join(c.MkDir(), "charm")
err = bundle.ExpandTo(path)
c.Assert(err, gc.ErrorMatches, `cannot extract "hooks/badlink": symlink "../../target" leads out of scope`)
// Symlink targeting an absolute path.
os.Remove(badLink)
err = os.Symlink("/target", badLink)
c.Assert(err, gc.IsNil)
bundle = extBundleDir(c, charmDir)
c.Assert(err, gc.IsNil)
path = filepath.Join(c.MkDir(), "charm")
err = bundle.ExpandTo(path)
c.Assert(err, gc.ErrorMatches, `cannot extract "hooks/badlink": symlink "/target" is absolute`)
}
func extBundleDirPath(c *gc.C, dirpath string) string {
path := filepath.Join(c.MkDir(), "bundle.charm")
cmd := exec.Command("/bin/sh", "-c", fmt.Sprintf("cd %s; zip --fifo --symlinks -r %s .", dirpath, path))
output, err := cmd.CombinedOutput()
c.Assert(err, gc.IsNil, gc.Commentf("Command output: %s", output))
return path
}
func extBundleDir(c *gc.C, dirpath string) *charm.Bundle {
path := extBundleDirPath(c, dirpath)
bundle, err := charm.ReadBundle(path)
c.Assert(err, gc.IsNil)
return bundle
}
func bundleDir(c *gc.C, dirpath string) *charm.Bundle {
dir, err := charm.ReadDir(dirpath)
c.Assert(err, gc.IsNil)
buf := new(bytes.Buffer)
err = dir.BundleTo(buf)
c.Assert(err, gc.IsNil)
bundle, err := charm.ReadBundleBytes(buf.Bytes())
c.Assert(err, gc.IsNil)
return bundle
}