/
tools_test.go
246 lines (212 loc) · 8.26 KB
/
tools_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
// Copyright 2012, 2013 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package apiserver_test
import (
"encoding/json"
"fmt"
"io/ioutil"
"net/http"
"net/url"
"path"
"github.com/juju/utils"
gc "launchpad.net/gocheck"
"github.com/juju/juju/environs/tools"
toolstesting "github.com/juju/juju/environs/tools/testing"
"github.com/juju/juju/state"
"github.com/juju/juju/state/api/params"
coretools "github.com/juju/juju/tools"
"github.com/juju/juju/version"
)
type toolsSuite struct {
authHttpSuite
}
var _ = gc.Suite(&toolsSuite{})
func (s *toolsSuite) SetUpSuite(c *gc.C) {
s.authHttpSuite.SetUpSuite(c)
s.archiveContentType = "application/x-tar-gz"
}
func (s *toolsSuite) TestToolsUploadedSecurely(c *gc.C) {
info := s.APIInfo(c)
uri := "http://" + info.Addrs[0] + "/tools"
_, err := s.sendRequest(c, "", "", "PUT", uri, "", nil)
c.Assert(err, gc.ErrorMatches, `.*malformed HTTP response.*`)
}
func (s *toolsSuite) TestRequiresAuth(c *gc.C) {
resp, err := s.sendRequest(c, "", "", "GET", s.toolsURI(c, ""), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusUnauthorized, "unauthorized")
}
func (s *toolsSuite) TestRequiresPOST(c *gc.C) {
resp, err := s.authRequest(c, "PUT", s.toolsURI(c, ""), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusMethodNotAllowed, `unsupported method: "PUT"`)
}
func (s *toolsSuite) TestAuthRequiresUser(c *gc.C) {
// Add a machine and try to login.
machine, err := s.State.AddMachine("quantal", state.JobHostUnits)
c.Assert(err, gc.IsNil)
err = machine.SetProvisioned("foo", "fake_nonce", nil)
c.Assert(err, gc.IsNil)
password, err := utils.RandomPassword()
c.Assert(err, gc.IsNil)
err = machine.SetPassword(password)
c.Assert(err, gc.IsNil)
resp, err := s.sendRequest(c, machine.Tag().String(), password, "POST", s.toolsURI(c, ""), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusUnauthorized, "unauthorized")
// Now try a user login.
resp, err = s.authRequest(c, "POST", s.toolsURI(c, ""), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusBadRequest, "expected binaryVersion argument")
}
func (s *toolsSuite) TestUploadRequiresVersion(c *gc.C) {
resp, err := s.authRequest(c, "POST", s.toolsURI(c, ""), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusBadRequest, "expected binaryVersion argument")
}
func (s *toolsSuite) TestUploadFailsWithNoTools(c *gc.C) {
// Create an empty file.
tempFile, err := ioutil.TempFile(c.MkDir(), "tools")
c.Assert(err, gc.IsNil)
resp, err := s.uploadRequest(c, s.toolsURI(c, "?binaryVersion=1.18.0-quantal-amd64"), true, tempFile.Name())
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusBadRequest, "no tools uploaded")
}
func (s *toolsSuite) TestUploadFailsWithInvalidContentType(c *gc.C) {
// Create an empty file.
tempFile, err := ioutil.TempFile(c.MkDir(), "tools")
c.Assert(err, gc.IsNil)
// Now try with the default Content-Type.
resp, err := s.uploadRequest(c, s.toolsURI(c, "?binaryVersion=1.18.0-quantal-amd64"), false, tempFile.Name())
c.Assert(err, gc.IsNil)
s.assertErrorResponse(
c, resp, http.StatusBadRequest, "expected Content-Type: application/x-tar-gz, got: application/octet-stream")
}
func (s *toolsSuite) setupToolsForUpload(c *gc.C) (coretools.List, version.Binary, string) {
localStorage := c.MkDir()
vers := version.MustParseBinary("1.9.0-quantal-amd64")
versionStrings := []string{vers.String()}
expectedTools := toolstesting.MakeToolsWithCheckSum(c, localStorage, "releases", versionStrings)
toolsFile := tools.StorageName(vers)
return expectedTools, vers, path.Join(localStorage, toolsFile)
}
func (s *toolsSuite) TestUpload(c *gc.C) {
// Make some fake tools.
expectedTools, vers, toolPath := s.setupToolsForUpload(c)
// Now try uploading them.
resp, err := s.uploadRequest(
c, s.toolsURI(c, "?binaryVersion="+vers.String()), true, toolPath)
c.Assert(err, gc.IsNil)
// Check the response.
stor := s.Environ.Storage()
toolsURL, err := stor.URL(tools.StorageName(vers))
c.Assert(err, gc.IsNil)
expectedTools[0].URL = toolsURL
s.assertUploadResponse(c, resp, expectedTools[0])
// Check the contents.
r, err := stor.Get(tools.StorageName(vers))
c.Assert(err, gc.IsNil)
uploadedData, err := ioutil.ReadAll(r)
c.Assert(err, gc.IsNil)
expectedData, err := ioutil.ReadFile(toolPath)
c.Assert(err, gc.IsNil)
c.Assert(uploadedData, gc.DeepEquals, expectedData)
}
func (s *toolsSuite) TestUploadAllowsTopLevelPath(c *gc.C) {
// Backwards compatibility check, that we can upload tools to
// https://host:port/tools
expectedTools, vers, toolPath := s.setupToolsForUpload(c)
url := s.toolsURL(c, "binaryVersion="+vers.String())
url.Path = "/tools"
resp, err := s.uploadRequest(c, url.String(), true, toolPath)
c.Assert(err, gc.IsNil)
// Check the response.
stor := s.Environ.Storage()
toolsURL, err := stor.URL(tools.StorageName(vers))
c.Assert(err, gc.IsNil)
expectedTools[0].URL = toolsURL
s.assertUploadResponse(c, resp, expectedTools[0])
}
func (s *toolsSuite) TestUploadAllowsEnvUUIDPath(c *gc.C) {
// Check that we can upload tools to https://host:port/ENVUUID/tools
environ, err := s.State.Environment()
c.Assert(err, gc.IsNil)
expectedTools, vers, toolPath := s.setupToolsForUpload(c)
url := s.toolsURL(c, "binaryVersion="+vers.String())
url.Path = fmt.Sprintf("/environment/%s/tools", environ.UUID())
resp, err := s.uploadRequest(c, url.String(), true, toolPath)
c.Assert(err, gc.IsNil)
// Check the response.
stor := s.Environ.Storage()
toolsURL, err := stor.URL(tools.StorageName(vers))
c.Assert(err, gc.IsNil)
expectedTools[0].URL = toolsURL
s.assertUploadResponse(c, resp, expectedTools[0])
}
func (s *toolsSuite) TestUploadRejectsWrongEnvUUIDPath(c *gc.C) {
// Check that we cannot access the tools at https://host:port/BADENVUUID/tools
url := s.toolsURL(c, "")
url.Path = "/environment/dead-beef-123456/tools"
resp, err := s.authRequest(c, "POST", url.String(), "", nil)
c.Assert(err, gc.IsNil)
s.assertErrorResponse(c, resp, http.StatusNotFound, `unknown environment: "dead-beef-123456"`)
}
func (s *toolsSuite) TestUploadFakeSeries(c *gc.C) {
// Make some fake tools.
expectedTools, vers, toolPath := s.setupToolsForUpload(c)
// Now try uploading them.
params := "?binaryVersion=" + vers.String() + "&series=precise,trusty"
resp, err := s.uploadRequest(c, s.toolsURI(c, params), true, toolPath)
c.Assert(err, gc.IsNil)
// Check the response.
stor := s.Environ.Storage()
toolsURL, err := stor.URL(tools.StorageName(vers))
c.Assert(err, gc.IsNil)
expectedTools[0].URL = toolsURL
s.assertUploadResponse(c, resp, expectedTools[0])
// Check the contents.
for _, series := range []string{"precise", "quantal", "trusty"} {
toolsVersion := vers
toolsVersion.Series = series
r, err := stor.Get(tools.StorageName(toolsVersion))
c.Assert(err, gc.IsNil)
uploadedData, err := ioutil.ReadAll(r)
c.Assert(err, gc.IsNil)
expectedData, err := ioutil.ReadFile(toolPath)
c.Assert(err, gc.IsNil)
c.Assert(uploadedData, gc.DeepEquals, expectedData)
}
}
func (s *toolsSuite) toolsURL(c *gc.C, query string) *url.URL {
uri := s.baseURL(c)
uri.Path += "/tools"
uri.RawQuery = query
return uri
}
func (s *toolsSuite) toolsURI(c *gc.C, query string) string {
if query != "" && query[0] == '?' {
query = query[1:]
}
return s.toolsURL(c, query).String()
}
func (s *toolsSuite) assertUploadResponse(c *gc.C, resp *http.Response, agentTools *coretools.Tools) {
body := assertResponse(c, resp, http.StatusOK, "application/json")
toolsResult := jsonToolsResponse(c, body)
c.Check(toolsResult.Error, gc.IsNil)
c.Check(toolsResult.Tools, gc.DeepEquals, agentTools)
}
func (s *toolsSuite) assertGetFileResponse(c *gc.C, resp *http.Response, expBody, expContentType string) {
body := assertResponse(c, resp, http.StatusOK, expContentType)
c.Check(string(body), gc.Equals, expBody)
}
func (s *toolsSuite) assertErrorResponse(c *gc.C, resp *http.Response, expCode int, expError string) {
body := assertResponse(c, resp, expCode, "application/json")
err := jsonToolsResponse(c, body).Error
c.Assert(err, gc.NotNil)
c.Check(err, gc.ErrorMatches, expError)
}
func jsonToolsResponse(c *gc.C, body []byte) (jsonResponse params.ToolsResult) {
err := json.Unmarshal(body, &jsonResponse)
c.Assert(err, gc.IsNil)
return
}