/
resolver_test.go
254 lines (225 loc) · 8.38 KB
/
resolver_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
// Copyright 2015 Canonical Ltd.
// Licensed under the AGPLv3, see LICENCE file for details.
package uniter_test
import (
"github.com/juju/errors"
"github.com/juju/testing"
jc "github.com/juju/testing/checkers"
gc "gopkg.in/check.v1"
"gopkg.in/juju/charm.v6-unstable"
"gopkg.in/juju/charm.v6-unstable/hooks"
"gopkg.in/juju/names.v2"
"github.com/juju/juju/apiserver/params"
"github.com/juju/juju/worker/uniter"
uniteractions "github.com/juju/juju/worker/uniter/actions"
"github.com/juju/juju/worker/uniter/hook"
"github.com/juju/juju/worker/uniter/leadership"
"github.com/juju/juju/worker/uniter/operation"
"github.com/juju/juju/worker/uniter/relation"
"github.com/juju/juju/worker/uniter/remotestate"
"github.com/juju/juju/worker/uniter/resolver"
"github.com/juju/juju/worker/uniter/storage"
)
type resolverSuite struct {
stub testing.Stub
charmModifiedVersion int
charmURL *charm.URL
remoteState remotestate.Snapshot
opFactory operation.Factory
resolver resolver.Resolver
resolverConfig uniter.ResolverConfig
clearResolved func() error
reportHookError func(hook.Info) error
}
var _ = gc.Suite(&resolverSuite{})
func (s *resolverSuite) SetUpTest(c *gc.C) {
s.stub = testing.Stub{}
s.charmURL = charm.MustParseURL("cs:precise/mysql-2")
s.remoteState = remotestate.Snapshot{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
}
s.opFactory = operation.NewFactory(operation.FactoryParams{})
attachments, err := storage.NewAttachments(&dummyStorageAccessor{}, names.NewUnitTag("u/0"), c.MkDir(), nil)
c.Assert(err, jc.ErrorIsNil)
s.clearResolved = func() error {
return errors.New("unexpected resolved")
}
s.reportHookError = func(hook.Info) error {
return errors.New("unexpected report hook error")
}
s.resolverConfig = uniter.ResolverConfig{
ClearResolved: func() error { return s.clearResolved() },
ReportHookError: func(info hook.Info) error { return s.reportHookError(info) },
StartRetryHookTimer: func() { s.stub.AddCall("StartRetryHookTimer") },
StopRetryHookTimer: func() { s.stub.AddCall("StopRetryHookTimer") },
ShouldRetryHooks: true,
Leadership: leadership.NewResolver(),
Actions: uniteractions.NewResolver(),
Relations: relation.NewRelationsResolver(&dummyRelations{}),
Storage: storage.NewResolver(attachments),
Commands: nopResolver{},
}
s.resolver = uniter.NewUniterResolver(s.resolverConfig)
}
// TestStartedNotInstalled tests whether the Started flag overrides the
// Installed flag being unset, in the event of an unexpected inconsistency in
// local state.
func (s *resolverSuite) TestStartedNotInstalled(c *gc.C) {
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.Continue,
Installed: false,
Started: true,
},
}
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
}
// TestNotStartedNotInstalled tests whether the next operation for an
// uninstalled local state is an install hook operation.
func (s *resolverSuite) TestNotStartedNotInstalled(c *gc.C) {
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.Continue,
Installed: false,
Started: false,
},
}
op, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, jc.ErrorIsNil)
c.Assert(op.String(), gc.Equals, "run install hook")
}
func (s *resolverSuite) TestHookErrorDoesNotStartRetryTimerIfShouldRetryFalse(c *gc.C) {
s.resolverConfig.ShouldRetryHooks = false
s.resolver = uniter.NewUniterResolver(s.resolverConfig)
s.reportHookError = func(hook.Info) error { return nil }
localState := resolver.LocalState{
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.RunHook,
Step: operation.Pending,
Installed: true,
Started: true,
Hook: &hook.Info{
Kind: hooks.ConfigChanged,
},
},
}
// Run the resolver; we should not attempt a hook retry
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckNoCalls(c)
}
func (s *resolverSuite) TestHookErrorStartRetryTimer(c *gc.C) {
s.reportHookError = func(hook.Info) error { return nil }
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.RunHook,
Step: operation.Pending,
Installed: true,
Started: true,
Hook: &hook.Info{
Kind: hooks.ConfigChanged,
},
},
}
// Run the resolver twice; we should start the hook retry
// timer on the first time through, no change on the second.
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer")
_, err = s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer") // no change
}
func (s *resolverSuite) TestHookErrorStartRetryTimerAgain(c *gc.C) {
s.reportHookError = func(hook.Info) error { return nil }
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.RunHook,
Step: operation.Pending,
Installed: true,
Started: true,
Hook: &hook.Info{
Kind: hooks.ConfigChanged,
},
},
}
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer")
s.remoteState.RetryHookVersion = 1
op, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, jc.ErrorIsNil)
c.Assert(op.String(), gc.Equals, "run config-changed hook")
s.stub.CheckCallNames(c, "StartRetryHookTimer") // no change
localState.RetryHookVersion = 1
_, err = s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer", "StartRetryHookTimer")
}
func (s *resolverSuite) TestResolvedRetryHooksStopRetryTimer(c *gc.C) {
// Resolving a failed hook should stop the retry timer.
s.testResolveHookErrorStopRetryTimer(c, params.ResolvedRetryHooks)
}
func (s *resolverSuite) TestResolvedNoHooksStopRetryTimer(c *gc.C) {
// Resolving a failed hook should stop the retry timer.
s.testResolveHookErrorStopRetryTimer(c, params.ResolvedNoHooks)
}
func (s *resolverSuite) testResolveHookErrorStopRetryTimer(c *gc.C, mode params.ResolvedMode) {
s.stub.ResetCalls()
s.clearResolved = func() error { return nil }
s.reportHookError = func(hook.Info) error { return nil }
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.RunHook,
Step: operation.Pending,
Installed: true,
Started: true,
Hook: &hook.Info{
Kind: hooks.ConfigChanged,
},
},
}
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer")
s.remoteState.ResolvedMode = mode
_, err = s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, jc.ErrorIsNil)
s.stub.CheckCallNames(c, "StartRetryHookTimer", "StopRetryHookTimer")
}
func (s *resolverSuite) TestRunHookStopRetryTimer(c *gc.C) {
s.reportHookError = func(hook.Info) error { return nil }
localState := resolver.LocalState{
CharmModifiedVersion: s.charmModifiedVersion,
CharmURL: s.charmURL,
State: operation.State{
Kind: operation.RunHook,
Step: operation.Pending,
Installed: true,
Started: true,
Hook: &hook.Info{
Kind: hooks.ConfigChanged,
},
},
}
_, err := s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer")
localState.Kind = operation.Continue
_, err = s.resolver.NextOp(localState, s.remoteState, s.opFactory)
c.Assert(err, gc.Equals, resolver.ErrNoOperation)
s.stub.CheckCallNames(c, "StartRetryHookTimer", "StopRetryHookTimer")
}