forked from cloudfoundry-attic/bosh-init
/
reader_test.go
231 lines (203 loc) · 6.52 KB
/
reader_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
package release_test
import (
"errors"
. "github.com/cloudfoundry/bosh-init/internal/github.com/onsi/ginkgo"
. "github.com/cloudfoundry/bosh-init/internal/github.com/onsi/gomega"
. "github.com/cloudfoundry/bosh-init/release"
fakecmd "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/fileutil/fakes"
fakesys "github.com/cloudfoundry/bosh-init/internal/github.com/cloudfoundry/bosh-utils/system/fakes"
bireljob "github.com/cloudfoundry/bosh-init/release/job"
birelpkg "github.com/cloudfoundry/bosh-init/release/pkg"
)
var _ = Describe("tarReader", func() {
var (
reader Reader
fakeFs *fakesys.FakeFileSystem
compressor *fakecmd.FakeCompressor
)
BeforeEach(func() {
fakeFs = fakesys.NewFakeFileSystem()
compressor = fakecmd.NewFakeCompressor()
reader = NewReader("/some/release.tgz", "/extracted/release", fakeFs, compressor)
})
Describe("Read", func() {
Context("when the given release archive is a valid tar", func() {
Context("when the release manifest is valid", func() {
BeforeEach(func() {
fakeFs.WriteFileString(
"/extracted/release/release.MF",
`---
name: fake-release
version: fake-version
commit_hash: abc123
uncommitted_changes: true
jobs:
- name: fake-job
version: fake-job-version
fingerprint: fake-job-fingerprint
sha1: fake-job-sha
packages:
- name: fake-package
version: fake-package-version
fingerprint: fake-package-fingerprint
sha1: fake-package-sha
dependencies:
- fake-package-1
`,
)
})
Context("when the jobs and packages in the release are valid", func() {
BeforeEach(func() {
fakeFs.WriteFileString(
"/extracted/release/extracted_jobs/fake-job/job.MF",
`---
name: fake-job
templates:
some_template: some_file
packages:
- fake-package
`,
)
})
Context("when the packages in the release are valid", func() {
It("returns a release from the given tar file", func() {
release, err := reader.Read()
Expect(err).NotTo(HaveOccurred())
expectedPackage := &birelpkg.Package{
Name: "fake-package",
Fingerprint: "fake-package-fingerprint",
SHA1: "fake-package-sha",
Dependencies: []*birelpkg.Package{&birelpkg.Package{Name: "fake-package-1"}},
ExtractedPath: "/extracted/release/extracted_packages/fake-package",
ArchivePath: "/extracted/release/packages/fake-package.tgz",
}
Expect(release.Name()).To(Equal("fake-release"))
Expect(release.Version()).To(Equal("fake-version"))
Expect(release.Jobs()).To(Equal([]bireljob.Job{
{
Name: "fake-job",
Fingerprint: "fake-job-fingerprint",
SHA1: "fake-job-sha",
ExtractedPath: "/extracted/release/extracted_jobs/fake-job",
Templates: map[string]string{"some_template": "some_file"},
PackageNames: []string{"fake-package"},
Packages: []*birelpkg.Package{expectedPackage},
Properties: map[string]bireljob.PropertyDefinition{},
},
}))
Expect(release.Packages()).To(Equal([]*birelpkg.Package{expectedPackage}))
})
})
Context("when the package cannot be extracted", func() {
BeforeEach(func() {
compressor.DecompressFileToDirErr = errors.New("Extracting package 'fake-package'")
})
It("returns errors for each invalid package", func() {
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Extracting package 'fake-package'"))
})
})
})
Context("when the jobs in the release are not valid", func() {
BeforeEach(func() {
fakeFs.WriteFileString(
"/extracted/release/release.MF",
`---
name: fake-release
version: fake-version
jobs:
- name: fake-job
version: fake-job-version
fingerprint: fake-job-fingerprint
sha1: fake-job-sha
- name: fake-job-2
version: fake-job-2-version
fingerprint: fake-job-2-fingerprint
sha1: fake-job-2-sha
packages:
- name: fake-package
version: fake-package-version
fingerprint: fake-package-fingerprint
sha1: fake-package-sha
dependencies:
- fake-package-1
`,
)
})
It("returns errors for each invalid job", func() {
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Reading job 'fake-job' from archive"))
Expect(err.Error()).To(ContainSubstring("Reading job 'fake-job-2' from archive"))
})
})
Context("when an extracted job path cannot be created", func() {
BeforeEach(func() {
fakeFs.MkdirAllError = errors.New("")
})
It("returns err", func() {
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Creating extracted job path"))
})
})
})
Context("when the CPI release manifest is invalid", func() {
BeforeEach(func() {
fakeFs.WriteFileString("/extracted/release/release.MF", "{")
})
It("returns an error when the YAML in unparseable", func() {
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Parsing release manifest"))
})
It("returns an error when the release manifest is missing", func() {
fakeFs.RemoveAll("/extracted/release/release.MF")
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Reading release manifest"))
})
})
Context("when the job refers to a package that does not exist", func() {
It("returns error", func() {
releaseMFContents :=
`---
name: fake-release
version: fake-version
commit_hash: abc123
uncommitted_changes: true
jobs:
- name: fake-job
version: fake-job-version
fingerprint: fake-job-fingerprint
sha1: fake-job-sha
`
fakeFs.WriteFileString("/extracted/release/release.MF", releaseMFContents)
jobMFContents :=
`---
name: fake-job
templates:
some_template: some_file
packages:
- not_there
`
fakeFs.WriteFileString("/extracted/release/extracted_jobs/fake-job/job.MF", jobMFContents)
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Package not found"))
})
})
})
Context("when the CPI release is not a valid tar", func() {
BeforeEach(func() {
compressor.DecompressFileToDirErr = errors.New("fake-error")
})
It("returns err", func() {
_, err := reader.Read()
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("Extracting release"))
})
})
})
})