// updateService internal method to use when service has been validated
func (f *Facade) updateService(ctx datastore.Context, svc *service.Service) error {
id := strings.TrimSpace(svc.ID)
if id == "" {
return errors.New("empty Service.ID not allowed")
}
svc.ID = id
//add assignment info to service so it is availble in zk
f.fillServiceAddr(ctx, svc)
svcStore := f.serviceStore
// verify the service with name and parent does not collide with another existing service
if s, err := svcStore.FindChildService(ctx, svc.DeploymentID, svc.ParentServiceID, svc.Name); err != nil {
glog.Errorf("Could not verify service path for %s: %s", svc.Name, err)
return err
} else if s != nil {
if s.ID != svc.ID {
err := fmt.Errorf("service %s found at %s", svc.Name, svc.ParentServiceID)
glog.Errorf("Cannot update service %s: %s", svc.Name, err)
return err
}
}
oldSvc, err := svcStore.Get(ctx, svc.ID)
if err != nil {
return err
}
//Deal with Service Config Files
//For now always make sure originalConfigs stay the same, essentially they are immutable
svc.OriginalConfigs = oldSvc.OriginalConfigs
//check if config files haven't changed
if !reflect.DeepEqual(oldSvc.OriginalConfigs, svc.ConfigFiles) {
//lets validate Service before doing more work....
if err := svc.ValidEntity(); err != nil {
return err
}
tenantID, servicePath, err := f.getTenantIDAndPath(ctx, *svc)
if err != nil {
return err
}
newConfs := make(map[string]*serviceconfigfile.SvcConfigFile)
//config files are different, for each one that is different validate and add to newConfs
for key, oldConf := range oldSvc.OriginalConfigs {
if conf, found := svc.ConfigFiles[key]; found {
if !reflect.DeepEqual(oldConf, conf) {
newConf, err := serviceconfigfile.New(tenantID, servicePath, conf)
if err != nil {
return err
}
newConfs[key] = newConf
}
}
}
//Get current stored conf files and replace as needed
configStore := serviceconfigfile.NewStore()
existingConfs, err := configStore.GetConfigFiles(ctx, tenantID, servicePath)
if err != nil {
return err
}
foundConfs := make(map[string]*serviceconfigfile.SvcConfigFile)
for _, svcConfig := range existingConfs {
foundConfs[svcConfig.ConfFile.Filename] = svcConfig
}
//add or replace stored service config
for _, newConf := range newConfs {
if existing, found := foundConfs[newConf.ConfFile.Filename]; found {
newConf.ID = existing.ID
//delete it from stored confs, left overs will be deleted from DB
delete(foundConfs, newConf.ConfFile.Filename)
}
configStore.Put(ctx, serviceconfigfile.Key(newConf.ID), newConf)
}
//remove leftover non-updated stored confs, conf was probably reverted to original or no longer exists
for _, confToDelete := range foundConfs {
configStore.Delete(ctx, serviceconfigfile.Key(confToDelete.ID))
}
}
svc.UpdatedAt = time.Now()
if err := svcStore.Put(ctx, svc); err != nil {
return err
}
// Remove the service from zookeeper if the pool ID has changed
if oldSvc.PoolID != svc.PoolID {
if err := zkAPI(f).RemoveService(oldSvc); err != nil {
// Synchronizer will eventually clean this service up
glog.Warningf("ZK: Could not delete service %s (%s) from pool %s: %s", svc.Name, svc.ID, oldSvc.PoolID, err)
oldSvc.DesiredState = int(service.SVCStop)
zkAPI(f).UpdateService(oldSvc)
}
}
return zkAPI(f).UpdateService(svc)
}