func (d expect) check(c *C, in chan state.RelationUnitsChange, out chan hook.Info) {
if d.hook == "" {
select {
case unexpected := <-out:
c.Fatalf("got %#v", unexpected)
case <-time.After(coretesting.ShortWait):
}
return
}
expect := hook.Info{
Kind: d.hook,
RelationId: 21345,
RemoteUnit: d.unit,
ChangeVersion: d.version,
}
if d.members != nil {
expect.Members = map[string]map[string]interface{}{}
for name, version := range d.members {
expect.Members[name] = settings(name, version)
}
}
select {
case actual := <-out:
c.Assert(actual, DeepEquals, expect)
case <-time.After(coretesting.LongWait):
c.Fatalf("timed out waiting for %#v", expect)
}
}
func (s *RelationerSuite) TestPrepareCommitHooks(c *C) {
r := uniter.NewRelationer(s.ru, s.dir, s.hooks)
err := r.Join()
c.Assert(err, IsNil)
ctx := r.Context()
c.Assert(ctx.UnitNames(), HasLen, 0)
// Check preparing an invalid hook changes nothing.
changed := hook.Info{
Kind: hook.RelationChanged,
RemoteUnit: "u/1",
ChangeVersion: 7,
Members: map[string]map[string]interface{}{
"u/1": {"private-address": "glastonbury"},
},
}
_, err = r.PrepareHook(changed)
c.Assert(err, ErrorMatches, `inappropriate "relation-changed" for "u/1": unit has not joined`)
c.Assert(ctx.UnitNames(), HasLen, 0)
c.Assert(s.dir.State().Members, HasLen, 0)
// Check preparing a valid hook updates the context, but not persistent
// relation state.
joined := hook.Info{
Kind: hook.RelationJoined,
RemoteUnit: "u/1",
Members: map[string]map[string]interface{}{
"u/1": {"private-address": "u-1.example.com"},
},
}
name, err := r.PrepareHook(joined)
c.Assert(err, IsNil)
c.Assert(s.dir.State().Members, HasLen, 0)
c.Assert(name, Equals, "my-relation-relation-joined")
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1"})
s1, err := ctx.ReadSettings("u/1")
c.Assert(err, IsNil)
c.Assert(s1, DeepEquals, joined.Members["u/1"])
// Clear the changed hook's Members, as though it had been deserialized.
changed.Members = nil
// Check that preparing the following hook fails as before...
_, err = r.PrepareHook(changed)
c.Assert(err, ErrorMatches, `inappropriate "relation-changed" for "u/1": unit has not joined`)
c.Assert(s.dir.State().Members, HasLen, 0)
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1"})
s1, err = ctx.ReadSettings("u/1")
c.Assert(err, IsNil)
c.Assert(s1, DeepEquals, joined.Members["u/1"])
// ...but that committing the previous hook updates the persistent
// relation state...
err = r.CommitHook(joined)
c.Assert(err, IsNil)
c.Assert(s.dir.State().Members, DeepEquals, map[string]int64{"u/1": 0})
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1"})
s1, err = ctx.ReadSettings("u/1")
c.Assert(err, IsNil)
c.Assert(s1, DeepEquals, joined.Members["u/1"])
// ...and allows us to prepare the next hook...
name, err = r.PrepareHook(changed)
c.Assert(err, IsNil)
c.Assert(name, Equals, "my-relation-relation-changed")
c.Assert(s.dir.State().Members, DeepEquals, map[string]int64{"u/1": 0})
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1"})
s1, err = ctx.ReadSettings("u/1")
c.Assert(err, IsNil)
c.Assert(s1, DeepEquals, map[string]interface{}{"private-address": "u-1.example.com"})
// ...and commit it.
err = r.CommitHook(changed)
c.Assert(err, IsNil)
c.Assert(s.dir.State().Members, DeepEquals, map[string]int64{"u/1": 7})
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1"})
// To verify implied behaviour above, prepare a new joined hook with
// missing membership information, and check relation context
// membership is updated appropriately...
joined.RemoteUnit = "u/2"
joined.ChangeVersion = 3
joined.Members = nil
name, err = r.PrepareHook(joined)
c.Assert(err, IsNil)
c.Assert(s.dir.State().Members, HasLen, 1)
c.Assert(name, Equals, "my-relation-relation-joined")
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1", "u/2"})
// ...and so is relation state on commit.
err = r.CommitHook(joined)
c.Assert(err, IsNil)
c.Assert(s.dir.State().Members, DeepEquals, map[string]int64{"u/1": 7, "u/2": 3})
c.Assert(ctx.UnitNames(), DeepEquals, []string{"u/1", "u/2"})
}
