// LaunchEditor launches the default editor configured for the given repo. This // method blocks until the editor command has returned. // // The specified filename should be a temporary file and provided as a relative path // from the repo (e.g. "FILENAME" will be converted to ".git/FILENAME"). This file // will be deleted after the editor is closed and its contents have been read. // // This method returns the text that was read from the temporary file, or // an error if any step in the process failed. func LaunchEditor(repo repository.Repo, fileName string) (string, error) { editor, err := repo.GetCoreEditor() if err != nil { return "", fmt.Errorf("Unable to detect default git editor: %v\n", err) } path := fmt.Sprintf("%s/.git/%s", repo.GetPath(), fileName) cmd, err := startInlineCommand(editor, path) if err != nil { // Running the editor directly did not work. This might mean that // the editor string is not a path to an executable, but rather // a shell command (e.g. "emacsclient --tty"). As such, we'll try // to run the command through bash, and if that fails, try with sh args := []string{"-c", fmt.Sprintf("%s %q", editor, path)} cmd, err = startInlineCommand("bash", args...) if err != nil { cmd, err = startInlineCommand("sh", args...) } } if err != nil { return "", fmt.Errorf("Unable to start editor: %v\n", err) } if err := cmd.Wait(); err != nil { return "", fmt.Errorf("Editing finished with error: %v\n", err) } output, err := ioutil.ReadFile(path) if err != nil { os.Remove(path) return "", fmt.Errorf("Error reading edited file: %v\n", err) } os.Remove(path) return string(output), err }
// commentOnReview adds a comment to the current code review. func commentOnReview(repo repository.Repo, args []string) error { commentFlagSet.Parse(args) args = commentFlagSet.Args() var r *review.Review var err error if len(args) > 1 { return errors.New("Only accepting a single review is supported.") } if len(args) == 1 { r, err = review.Get(repo, args[0]) } else { r, err = review.GetCurrent(repo) } if err != nil { return fmt.Errorf("Failed to load the review: %v\n", err) } if r == nil { return errors.New("There is no matching review.") } if *commentLgtm && *commentNmw { return errors.New("You cannot combine the flags -lgtm and -nmw.") } if *commentLine != 0 && *commentFile == "" { return errors.New("Specifying a line number with the -l flag requires that you also specify a file name with the -f flag.") } if *commentParent != "" && !commentHashExists(*commentParent, r.Comments) { return errors.New("There is no matching parent comment.") } if *commentMessage == "" { editor, err := repo.GetCoreEditor() if err != nil { return fmt.Errorf("Unable to detect default git editor: %v\n", err) } path := fmt.Sprintf("%s/.git/%s", repo.GetPath(), commentFilename) cmd := exec.Command(editor, path) cmd.Stdin = os.Stdin cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr err = cmd.Start() if err != nil { return fmt.Errorf("Unable to start editor: %v\n", err) } err = cmd.Wait() if err != nil { return fmt.Errorf("Editing finished with error: %v\n", err) } comment, err := ioutil.ReadFile(path) if err != nil { os.Remove(path) return fmt.Errorf("Error reading comment file: %v\n", err) } *commentMessage = string(comment) os.Remove(path) } commentedUponCommit, err := r.GetHeadCommit() if err != nil { return err } location := comment.Location{ Commit: commentedUponCommit, } if *commentFile != "" { location.Path = *commentFile if *commentLine != 0 { location.Range = &comment.Range{ StartLine: uint32(*commentLine), } } } userEmail, err := repo.GetUserEmail() if err != nil { return err } c := comment.New(userEmail, *commentMessage) c.Location = &location c.Parent = *commentParent if *commentLgtm || *commentNmw { resolved := *commentLgtm c.Resolved = &resolved } return r.AddComment(c) }
// rejectReview adds an NMW comment to the current code review. func rejectReview(repo repository.Repo, args []string) error { rejectFlagSet.Parse(args) args = rejectFlagSet.Args() var r *review.Review var err error if len(args) > 1 { return errors.New("Only rejecting a single review is supported.") } if len(args) == 1 { r, err = review.Get(repo, args[0]) } else { r, err = review.GetCurrent(repo) } if err != nil { return fmt.Errorf("Failed to load the review: %v\n", err) } if r == nil { return errors.New("There is no matching review.") } if *rejectMessage == "" { editor, err := repo.GetCoreEditor() if err != nil { return fmt.Errorf("Unable to detect default git editor: %v\n", err) } path := fmt.Sprintf("%s/.git/%s", repo.GetPath(), rejectFilename) cmd := exec.Command(editor, path) cmd.Stdin = os.Stdin cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr err = cmd.Start() if err != nil { return fmt.Errorf("Unable to start editor: %v\n", err) } err = cmd.Wait() if err != nil { return fmt.Errorf("Editing finished with error: %v\n", err) } comment, err := ioutil.ReadFile(path) if err != nil { os.Remove(path) return fmt.Errorf("Error reading comment file: %v\n", err) } *rejectMessage = string(comment) os.Remove(path) } rejectedCommit, err := r.GetHeadCommit() if err != nil { return err } location := comment.Location{ Commit: rejectedCommit, } resolved := false userEmail, err := repo.GetUserEmail() if err != nil { return err } c := comment.New(userEmail, *rejectMessage) c.Location = &location c.Resolved = &resolved return r.AddComment(c) }