func TestDeploymentConfigStrategy(t *testing.T) {
ctx := kapi.NewDefaultContext()
if !Strategy.NamespaceScoped() {
t.Errorf("DeploymentConfig is namespace scoped")
}
if Strategy.AllowCreateOnUpdate() {
t.Errorf("DeploymentConfig should not allow create on update")
}
deploymentConfig := &deployapi.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "default"},
Template: deployapi.DeploymentTemplate{
Strategy: deploytest.OkStrategy(),
ControllerTemplate: deploytest.OkControllerTemplate(),
},
}
Strategy.PrepareForCreate(deploymentConfig)
errs := Strategy.Validate(ctx, deploymentConfig)
if len(errs) != 0 {
t.Errorf("Unexpected error validating %v", errs)
}
updatedDeploymentConfig := &deployapi.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "bar", Namespace: "default"},
Template: deployapi.DeploymentTemplate{
Strategy: deploytest.OkStrategy(),
ControllerTemplate: deploytest.OkControllerTemplate(),
},
}
errs = Strategy.ValidateUpdate(ctx, updatedDeploymentConfig, deploymentConfig)
if len(errs) == 0 {
t.Errorf("Expected error validating")
}
// name must match, and resource version must be provided
updatedDeploymentConfig.Name = "foo"
updatedDeploymentConfig.ResourceVersion = "1"
errs = Strategy.ValidateUpdate(ctx, updatedDeploymentConfig, deploymentConfig)
if len(errs) != 0 {
t.Errorf("Unexpected error validating %v", errs)
}
invalidDeploymentConfig := &deployapi.DeploymentConfig{}
errs = Strategy.Validate(ctx, invalidDeploymentConfig)
if len(errs) == 0 {
t.Errorf("Expected error validating")
}
}
func rollingConfig(interval, updatePeriod, timeout int) api.DeploymentConfig {
return api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkint64p(interval),
UpdatePeriodSeconds: mkint64p(updatePeriod),
TimeoutSeconds: mkint64p(timeout),
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
}
}
func rollingConfigMax(maxSurge, maxUnavailable kutil.IntOrString) api.DeploymentConfig {
return api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkint64p(1),
UpdatePeriodSeconds: mkint64p(1),
TimeoutSeconds: mkint64p(1),
MaxSurge: maxSurge,
MaxUnavailable: maxUnavailable,
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
}
}
func TestValidateDeploymentConfigMissingFields(t *testing.T) {
errorCases := map[string]struct {
D api.DeploymentConfig
T fielderrors.ValidationErrorType
F string
}{
"missing name": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "", Namespace: "bar"},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeRequired,
"metadata.name",
},
"missing namespace": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: ""},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeRequired,
"metadata.namespace",
},
"invalid name": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "-foo", Namespace: "bar"},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeInvalid,
"metadata.name",
},
"invalid namespace": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "-bar"},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeInvalid,
"metadata.namespace",
},
"missing trigger.type": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: []api.DeploymentTriggerPolicy{
{
ImageChangeParams: &api.DeploymentTriggerImageChangeParams{
ContainerNames: []string{"foo"},
},
},
},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeRequired,
"triggers[0].type",
},
"missing Trigger imageChangeParams.from": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: []api.DeploymentTriggerPolicy{
{
Type: api.DeploymentTriggerOnImageChange,
ImageChangeParams: &api.DeploymentTriggerImageChangeParams{
ContainerNames: []string{"foo"},
},
},
},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeRequired,
"triggers[0].imageChangeParams.from",
},
"invalid Trigger imageChangeParams.from.kind": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: []api.DeploymentTriggerPolicy{
{
Type: api.DeploymentTriggerOnImageChange,
ImageChangeParams: &api.DeploymentTriggerImageChangeParams{
From: kapi.ObjectReference{
Kind: "Invalid",
Name: "name",
},
ContainerNames: []string{"foo"},
},
},
},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeInvalid,
"triggers[0].imageChangeParams.from.kind",
},
"both fields illegal Trigger imageChangeParams.repositoryName": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: []api.DeploymentTriggerPolicy{
{
Type: api.DeploymentTriggerOnImageChange,
ImageChangeParams: &api.DeploymentTriggerImageChangeParams{
ContainerNames: []string{"foo"},
RepositoryName: "name",
From: kapi.ObjectReference{
Name: "other",
},
},
},
},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeInvalid,
"triggers[0].imageChangeParams.repositoryName",
},
"missing Trigger imageChangeParams.containerNames": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: []api.DeploymentTriggerPolicy{
{
Type: api.DeploymentTriggerOnImageChange,
ImageChangeParams: &api.DeploymentTriggerImageChangeParams{
RepositoryName: "foo",
},
},
},
Template: test.OkDeploymentTemplate(),
},
fielderrors.ValidationErrorTypeRequired,
"triggers[0].imageChangeParams.containerNames",
},
"missing strategy.type": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
CustomParams: test.OkCustomParams(),
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.type",
},
"missing strategy.customParams": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeCustom,
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.customParams",
},
"missing template.strategy.customParams.image": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeCustom,
CustomParams: &api.CustomDeploymentStrategyParams{},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.customParams.image",
},
"missing template.strategy.recreateParams.pre.failurePolicy": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRecreate,
RecreateParams: &api.RecreateDeploymentStrategyParams{
Pre: &api.LifecycleHook{
ExecNewPod: &api.ExecNewPodHook{
Command: []string{"cmd"},
ContainerName: "container",
},
},
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.recreateParams.pre.failurePolicy",
},
"missing template.strategy.recreateParams.pre.execNewPod": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRecreate,
RecreateParams: &api.RecreateDeploymentStrategyParams{
Pre: &api.LifecycleHook{
FailurePolicy: api.LifecycleHookFailurePolicyRetry,
},
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.recreateParams.pre.execNewPod",
},
"missing template.strategy.recreateParams.pre.execNewPod.command": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRecreate,
RecreateParams: &api.RecreateDeploymentStrategyParams{
Pre: &api.LifecycleHook{
FailurePolicy: api.LifecycleHookFailurePolicyRetry,
ExecNewPod: &api.ExecNewPodHook{
ContainerName: "container",
},
},
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.recreateParams.pre.execNewPod.command",
},
"missing template.strategy.recreateParams.pre.execNewPod.containerName": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRecreate,
RecreateParams: &api.RecreateDeploymentStrategyParams{
Pre: &api.LifecycleHook{
FailurePolicy: api.LifecycleHookFailurePolicyRetry,
ExecNewPod: &api.ExecNewPodHook{
Command: []string{"cmd"},
},
},
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.recreateParams.pre.execNewPod.containerName",
},
"invalid template.strategy.rollingParams.intervalSeconds": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkintp(-20),
UpdatePeriodSeconds: mkintp(1),
TimeoutSeconds: mkintp(1),
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeInvalid,
"template.strategy.rollingParams.intervalSeconds",
},
"invalid template.strategy.rollingParams.updatePeriodSeconds": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkintp(1),
UpdatePeriodSeconds: mkintp(-20),
TimeoutSeconds: mkintp(1),
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeInvalid,
"template.strategy.rollingParams.updatePeriodSeconds",
},
"invalid template.strategy.rollingParams.timeoutSeconds": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Triggers: manualTrigger(),
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkintp(1),
UpdatePeriodSeconds: mkintp(1),
TimeoutSeconds: mkintp(-20),
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeInvalid,
"template.strategy.rollingParams.timeoutSeconds",
},
"missing template.strategy.rollingParams.pre.failurePolicy": {
api.DeploymentConfig{
ObjectMeta: kapi.ObjectMeta{Name: "foo", Namespace: "bar"},
Template: api.DeploymentTemplate{
Strategy: api.DeploymentStrategy{
Type: api.DeploymentStrategyTypeRolling,
RollingParams: &api.RollingDeploymentStrategyParams{
IntervalSeconds: mkintp(1),
UpdatePeriodSeconds: mkintp(1),
TimeoutSeconds: mkintp(20),
Pre: &api.LifecycleHook{
ExecNewPod: &api.ExecNewPodHook{
Command: []string{"cmd"},
ContainerName: "container",
},
},
},
},
ControllerTemplate: test.OkControllerTemplate(),
},
},
fielderrors.ValidationErrorTypeRequired,
"template.strategy.rollingParams.pre.failurePolicy",
},
}
for k, v := range errorCases {
errs := ValidateDeploymentConfig(&v.D)
if len(errs) == 0 {
t.Errorf("Expected failure for scenario %s", k)
}
for i := range errs {
if errs[i].(*fielderrors.ValidationError).Type != v.T {
t.Errorf("%s: expected errors to have type %s: %v", k, v.T, errs[i])
}
if errs[i].(*fielderrors.ValidationError).Field != v.F {
t.Errorf("%s: expected errors to have field %s: %v", k, v.F, errs[i])
}
}
}
}