// findStreamForMapping retrieves an ImageStream whose DockerImageRepository matches dockerRepo. func (s *REST) findStreamForMapping(ctx kapi.Context, mapping *api.ImageStreamMapping) (*api.ImageStream, error) { if len(mapping.Name) > 0 { return s.imageStreamRegistry.GetImageStream(ctx, mapping.Name) } if len(mapping.DockerImageRepository) != 0 { list, err := s.imageStreamRegistry.ListImageStreams(ctx, labels.Everything()) if err != nil { return nil, err } for i := range list.Items { if mapping.DockerImageRepository == list.Items[i].Spec.DockerImageRepository { return &list.Items[i], nil } } return nil, errors.NewInvalid("imageStreamMapping", "", fielderrors.ValidationErrorList{ fielderrors.NewFieldNotFound("dockerImageStream", mapping.DockerImageRepository), }) } return nil, errors.NewNotFound("ImageStream", "") }
func TestNewInvalid(t *testing.T) { testCases := []struct { Err *fielderrors.ValidationError Details *unversioned.StatusDetails }{ { fielderrors.NewFieldDuplicate("field[0].name", "bar"), &unversioned.StatusDetails{ Kind: "kind", Name: "name", Causes: []unversioned.StatusCause{{ Type: unversioned.CauseTypeFieldValueDuplicate, Field: "field[0].name", }}, }, }, { fielderrors.NewFieldInvalid("field[0].name", "bar", "detail"), &unversioned.StatusDetails{ Kind: "kind", Name: "name", Causes: []unversioned.StatusCause{{ Type: unversioned.CauseTypeFieldValueInvalid, Field: "field[0].name", }}, }, }, { fielderrors.NewFieldNotFound("field[0].name", "bar"), &unversioned.StatusDetails{ Kind: "kind", Name: "name", Causes: []unversioned.StatusCause{{ Type: unversioned.CauseTypeFieldValueNotFound, Field: "field[0].name", }}, }, }, { fielderrors.NewFieldValueNotSupported("field[0].name", "bar", nil), &unversioned.StatusDetails{ Kind: "kind", Name: "name", Causes: []unversioned.StatusCause{{ Type: unversioned.CauseTypeFieldValueNotSupported, Field: "field[0].name", }}, }, }, { fielderrors.NewFieldRequired("field[0].name"), &unversioned.StatusDetails{ Kind: "kind", Name: "name", Causes: []unversioned.StatusCause{{ Type: unversioned.CauseTypeFieldValueRequired, Field: "field[0].name", }}, }, }, } for i, testCase := range testCases { vErr, expected := testCase.Err, testCase.Details expected.Causes[0].Message = vErr.ErrorBody() err := NewInvalid("kind", "name", fielderrors.ValidationErrorList{vErr}) status := err.(*StatusError).ErrStatus if status.Code != 422 || status.Reason != unversioned.StatusReasonInvalid { t.Errorf("%d: unexpected status: %#v", i, status) } if !reflect.DeepEqual(expected, status.Details) { t.Errorf("%d: expected %#v, got %#v", i, expected, status.Details) } } }
// tagsChanged updates stream.Status.Tags based on the old and new image stream. // if the old stream is nil, all tags are considered additions. func (s Strategy) tagsChanged(old, stream *api.ImageStream) fielderrors.ValidationErrorList { var errs fielderrors.ValidationErrorList oldTags := map[string]api.TagReference{} if old != nil && old.Spec.Tags != nil { oldTags = old.Spec.Tags } for tag, tagRef := range stream.Spec.Tags { if oldRef, ok := oldTags[tag]; ok && !tagRefChanged(oldRef, tagRef, stream.Namespace) { continue } if tagRef.From == nil { continue } if tagRef.From.Kind == "DockerImage" && len(tagRef.From.Name) > 0 { if tagRef.Reference { event, err := tagReferenceToTagEvent(stream, tagRef, "") if err != nil { errs = append(errs, fielderrors.NewFieldInvalid(fmt.Sprintf("spec.tags[%s].from", tag), tagRef.From, err.Error())) continue } api.AddTagEventToImageStream(stream, tag, *event) } continue } tagRefStreamName, tagOrID, err := parseFromReference(stream, tagRef.From) if err != nil { errs = append(errs, fielderrors.NewFieldInvalid(fmt.Sprintf("spec.tags[%s].from.name", tag), tagRef.From.Name, "must be of the form <tag>, <repo>:<tag>, <id>, or <repo>@<id>")) continue } streamRef := stream streamRefNamespace := tagRef.From.Namespace if len(streamRefNamespace) == 0 { streamRefNamespace = stream.Namespace } if streamRefNamespace != stream.Namespace || tagRefStreamName != stream.Name { obj, err := s.ImageStreamGetter.Get(kapi.WithNamespace(kapi.NewContext(), streamRefNamespace), tagRefStreamName) if err != nil { if kerrors.IsNotFound(err) { errs = append(errs, fielderrors.NewFieldNotFound(fmt.Sprintf("spec.tags[%s].from.name", tag), tagRef.From.Name)) } else { errs = append(errs, fielderrors.NewFieldInvalid(fmt.Sprintf("spec.tags[%s].from.name", tag), tagRef.From.Name, fmt.Sprintf("unable to retrieve image stream: %v", err))) } continue } streamRef = obj.(*api.ImageStream) } event, err := tagReferenceToTagEvent(streamRef, tagRef, tagOrID) if err != nil { errs = append(errs, fielderrors.NewFieldInvalid(fmt.Sprintf("spec.tags[%s].from.name", tag), tagRef.From.Name, fmt.Sprintf("error generating tag event: %v", err))) continue } if event == nil { // referenced tag or ID doesn't exist, which is ok continue } api.AddTagEventToImageStream(stream, tag, *event) } if old != nil { api.UpdateChangedTrackingTags(stream, old) } // use a consistent timestamp on creation if old == nil && !stream.CreationTimestamp.IsZero() { for tag, list := range stream.Status.Tags { for _, event := range list.Items { event.Created = stream.CreationTimestamp } stream.Status.Tags[tag] = list } } return errs }