func validatePorts(ports []Port) errs.ErrorList { allErrs := errs.ErrorList{} allNames := util.StringSet{} for i := range ports { pErrs := errs.ErrorList{} port := &ports[i] // so we can set default values if len(port.Name) > 0 { if len(port.Name) > 63 || !util.IsDNSLabel(port.Name) { pErrs = append(pErrs, errs.NewInvalid("name", port.Name)) } else if allNames.Has(port.Name) { pErrs = append(pErrs, errs.NewDuplicate("name", port.Name)) } else { allNames.Insert(port.Name) } } if port.ContainerPort == 0 { pErrs = append(pErrs, errs.NewRequired("containerPort", port.ContainerPort)) } else if !util.IsValidPortNum(port.ContainerPort) { pErrs = append(pErrs, errs.NewInvalid("containerPort", port.ContainerPort)) } if port.HostPort != 0 && !util.IsValidPortNum(port.HostPort) { pErrs = append(pErrs, errs.NewInvalid("hostPort", port.HostPort)) } if len(port.Protocol) == 0 { port.Protocol = "TCP" } else if !supportedPortProtocols.Has(strings.ToUpper(port.Protocol)) { pErrs = append(pErrs, errs.NewNotSupported("protocol", port.Protocol)) } allErrs = append(allErrs, pErrs.PrefixIndex(i)...) } return allErrs }
func validateVolumes(volumes []Volume) (util.StringSet, errs.ErrorList) { allErrs := errs.ErrorList{} allNames := util.StringSet{} for i := range volumes { vol := &volumes[i] // so we can set default values el := errs.ErrorList{} // TODO(thockin) enforce that a source is set once we deprecate the implied form. if vol.Source != nil { el = validateSource(vol.Source).Prefix("source") } if len(vol.Name) == 0 { el = append(el, errs.NewRequired("name", vol.Name)) } else if !util.IsDNSLabel(vol.Name) { el = append(el, errs.NewInvalid("name", vol.Name)) } else if allNames.Has(vol.Name) { el = append(el, errs.NewDuplicate("name", vol.Name)) } if len(el) == 0 { allNames.Insert(vol.Name) } else { allErrs = append(allErrs, el.PrefixIndex(i)...) } } return allNames, allErrs }
func validateContainers(containers []Container, volumes util.StringSet) errs.ErrorList { allErrs := errs.ErrorList{} allNames := util.StringSet{} for i := range containers { cErrs := errs.ErrorList{} ctr := &containers[i] // so we can set default values if len(ctr.Name) == 0 { cErrs = append(cErrs, errs.NewRequired("name", ctr.Name)) } else if !util.IsDNSLabel(ctr.Name) { cErrs = append(cErrs, errs.NewInvalid("name", ctr.Name)) } else if allNames.Has(ctr.Name) { cErrs = append(cErrs, errs.NewDuplicate("name", ctr.Name)) } else { allNames.Insert(ctr.Name) } if len(ctr.Image) == 0 { cErrs = append(cErrs, errs.NewRequired("image", ctr.Image)) } cErrs = append(cErrs, validatePorts(ctr.Ports).Prefix("ports")...) cErrs = append(cErrs, validateEnv(ctr.Env).Prefix("env")...) cErrs = append(cErrs, validateVolumeMounts(ctr.VolumeMounts, volumes).Prefix("volumeMounts")...) allErrs = append(allErrs, cErrs.PrefixIndex(i)...) } // Check for colliding ports across all containers. // TODO(thockin): This really is dependent on the network config of the host (IP per pod?) // and the config of the new manifest. But we have not specced that out yet, so we'll just // make some assumptions for now. As of now, pods share a network namespace, which means that // every Port.HostPort across the whole pod must be unique. allErrs = append(allErrs, checkHostPortConflicts(containers)...) return allErrs }
func validatePorts(ports []Port) errs.ErrorList { allErrs := errs.ErrorList{} allNames := util.StringSet{} for i := range ports { port := &ports[i] // so we can set default values if len(port.Name) > 0 { if len(port.Name) > 63 || !util.IsDNSLabel(port.Name) { allErrs.Append(errs.NewInvalid("Port.Name", port.Name)) } else if allNames.Has(port.Name) { allErrs.Append(errs.NewDuplicate("Port.name", port.Name)) } else { allNames.Insert(port.Name) } } if !util.IsValidPortNum(port.ContainerPort) { allErrs.Append(errs.NewInvalid("Port.ContainerPort", port.ContainerPort)) } if port.HostPort == 0 { port.HostPort = port.ContainerPort } else if !util.IsValidPortNum(port.HostPort) { allErrs.Append(errs.NewInvalid("Port.HostPort", port.HostPort)) } if len(port.Protocol) == 0 { port.Protocol = "TCP" } else if !supportedPortProtocols.Has(strings.ToUpper(port.Protocol)) { allErrs.Append(errs.NewNotSupported("Port.Protocol", port.Protocol)) } } return allErrs }
// AccumulateUniquePorts runs an extraction function on each Port of each Container, // accumulating the results and returning an error if any ports conflict. func AccumulateUniquePorts(containers []Container, accumulator map[int]bool, extract func(*Port) int) errs.ErrorList { allErrs := errs.ErrorList{} for ci := range containers { ctr := &containers[ci] for pi := range ctr.Ports { port := extract(&ctr.Ports[pi]) if accumulator[port] { allErrs.Append(errs.NewDuplicate("Port", port)) } else { accumulator[port] = true } } } return allErrs }
func filterInvalidPods(pods []kubelet.Pod, source string) (filtered []*kubelet.Pod) { names := util.StringSet{} for i := range pods { var errors []error if names.Has(pods[i].Name) { errors = append(errors, apierrs.NewDuplicate("Pod.Name", pods[i].Name)) } else { names.Insert(pods[i].Name) } if errs := kubelet.ValidatePod(&pods[i]); len(errs) != 0 { errors = append(errors, errs...) } if len(errors) > 0 { glog.Warningf("Pod %d from %s failed validation, ignoring: %v", i+1, source, errors) continue } filtered = append(filtered, &pods[i]) } return }
// AccumulateUniquePorts runs an extraction function on each Port of each Container, // accumulating the results and returning an error if any ports conflict. func AccumulateUniquePorts(containers []Container, accumulator map[int]bool, extract func(*Port) int) errs.ErrorList { allErrs := errs.ErrorList{} for ci := range containers { cErrs := errs.ErrorList{} ctr := &containers[ci] for pi := range ctr.Ports { port := extract(&ctr.Ports[pi]) if port == 0 { continue } if accumulator[port] { cErrs = append(cErrs, errs.NewDuplicate("Port", port)) } else { accumulator[port] = true } } allErrs = append(allErrs, cErrs.PrefixIndex(ci)...) } return allErrs }
func TestNewInvalidErr(t *testing.T) { testCases := []struct { Err apierrors.ValidationError Details *api.StatusDetails }{ { apierrors.NewDuplicate("field[0].name", "bar"), &api.StatusDetails{ Kind: "kind", ID: "name", Causes: []api.StatusCause{{ Type: api.CauseTypeFieldValueDuplicate, Field: "field[0].name", }}, }, }, { apierrors.NewInvalid("field[0].name", "bar"), &api.StatusDetails{ Kind: "kind", ID: "name", Causes: []api.StatusCause{{ Type: api.CauseTypeFieldValueInvalid, Field: "field[0].name", }}, }, }, { apierrors.NewNotFound("field[0].name", "bar"), &api.StatusDetails{ Kind: "kind", ID: "name", Causes: []api.StatusCause{{ Type: api.CauseTypeFieldValueNotFound, Field: "field[0].name", }}, }, }, { apierrors.NewNotSupported("field[0].name", "bar"), &api.StatusDetails{ Kind: "kind", ID: "name", Causes: []api.StatusCause{{ Type: api.CauseTypeFieldValueNotSupported, Field: "field[0].name", }}, }, }, { apierrors.NewRequired("field[0].name", "bar"), &api.StatusDetails{ Kind: "kind", ID: "name", Causes: []api.StatusCause{{ Type: api.CauseTypeFieldValueRequired, Field: "field[0].name", }}, }, }, } for i := range testCases { vErr, expected := testCases[i].Err, testCases[i].Details expected.Causes[0].Message = vErr.Error() err := NewInvalidErr("kind", "name", apierrors.ErrorList{vErr}) status := errToAPIStatus(err) if status.Code != 422 || status.Reason != api.StatusReasonInvalid { t.Errorf("unexpected status: %#v", status) } if !reflect.DeepEqual(expected, status.Details) { t.Errorf("expected %#v, got %#v", expected, status.Details) } } }