func TestSubstituteImageCustomBaseMatchEnvMismatch(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForImageRepository()
output := mocks.MockOutput()
bc := mocks.MockBuildConfig(source, strategy, output)
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
// Full custom build with a Image and a well defined environment variable image value that does not match the new image
// Environment variables should not be updated.
build.Parameters.Strategy.CustomStrategy.Env = make([]kapi.EnvVar, 2)
build.Parameters.Strategy.CustomStrategy.Env[0] = kapi.EnvVar{Name: "someEnvVar", Value: originalImage}
build.Parameters.Strategy.CustomStrategy.Env[1] = kapi.EnvVar{Name: buildapi.CustomBuildStrategyBaseImageKey, Value: "dummy"}
updateCustomImageEnv(build.Parameters.Strategy.CustomStrategy, newImage)
if build.Parameters.Strategy.CustomStrategy.Env[0].Value != originalImage {
t.Errorf("Random env variable %s was improperly substituted in custom strategy", build.Parameters.Strategy.CustomStrategy.Env[0].Name)
}
if build.Parameters.Strategy.CustomStrategy.Env[1].Value != newImage {
t.Errorf("Image env variable was not substituted in custom strategy")
}
if c := len(build.Parameters.Strategy.CustomStrategy.Env); c != 2 {
t.Errorf("Expected %d, found %d environment variables", 2, c)
}
}
func TestSubstituteImageCustomBaseMatchEnvMissing(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForImageRepository()
output := mocks.MockOutput()
bc := mocks.MockBuildConfig(source, strategy, output)
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
// Custom build with a base Image but no image environment variable.
// base image should be replaced, new image environment variable should be added,
// existing environment variable should be untouched
build.Parameters.Strategy.CustomStrategy.Env = make([]kapi.EnvVar, 1)
build.Parameters.Strategy.CustomStrategy.Env[0] = kapi.EnvVar{Name: "someImage", Value: originalImage}
updateCustomImageEnv(build.Parameters.Strategy.CustomStrategy, newImage)
if build.Parameters.Strategy.CustomStrategy.Env[0].Value != originalImage {
t.Errorf("Random env variable was improperly substituted in custom strategy")
}
if build.Parameters.Strategy.CustomStrategy.Env[1].Name != buildapi.CustomBuildStrategyBaseImageKey || build.Parameters.Strategy.CustomStrategy.Env[1].Value != newImage {
t.Errorf("Image env variable was not added in custom strategy %s %s |", build.Parameters.Strategy.CustomStrategy.Env[1].Name, build.Parameters.Strategy.CustomStrategy.Env[1].Value)
}
if c := len(build.Parameters.Strategy.CustomStrategy.Env); c != 2 {
t.Errorf("Expected %d, found %d environment variables", 2, c)
}
}
func TestSubstituteImageCustomAllMatch(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForDockerImage(originalImage)
output := mocks.MockOutput()
bc := mocks.MockBuildConfig(source, strategy, output)
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
// Full custom build with a Image and a well defined environment variable image value,
// both should be replaced. Additional environment variables should not be touched.
build.Parameters.Strategy.CustomStrategy.Env = make([]kapi.EnvVar, 2)
build.Parameters.Strategy.CustomStrategy.Env[0] = kapi.EnvVar{Name: "someImage", Value: originalImage}
build.Parameters.Strategy.CustomStrategy.Env[1] = kapi.EnvVar{Name: buildapi.CustomBuildStrategyBaseImageKey, Value: originalImage}
updateCustomImageEnv(build.Parameters.Strategy.CustomStrategy, newImage)
if build.Parameters.Strategy.CustomStrategy.Env[0].Value != originalImage {
t.Errorf("Random env variable %s was improperly substituted in custom strategy", build.Parameters.Strategy.CustomStrategy.Env[0].Name)
}
if build.Parameters.Strategy.CustomStrategy.Env[1].Value != newImage {
t.Errorf("Image env variable was not properly substituted in custom strategy")
}
if c := len(build.Parameters.Strategy.CustomStrategy.Env); c != 2 {
t.Errorf("Expected %d, found %d environment variables", 2, c)
}
if bc.Parameters.Strategy.CustomStrategy.From.Name != originalImage {
t.Errorf("Custom BuildConfig Image was updated when Build was modified %s!=%s", bc.Parameters.Strategy.CustomStrategy.From.Name, originalImage)
}
if len(bc.Parameters.Strategy.CustomStrategy.Env) != 0 {
t.Errorf("Custom BuildConfig Env was updated when Build was modified")
}
}
func TestGenerateBuildFromBuild(t *testing.T) {
source := mocks.MockSource()
strategy := mockDockerStrategyForImageRepository()
output := mocks.MockOutput()
build := &buildapi.Build{
ObjectMeta: kapi.ObjectMeta{
Name: "test-build",
},
Parameters: buildapi.BuildParameters{
Source: source,
Revision: &buildapi.SourceRevision{
Type: buildapi.BuildSourceGit,
Git: &buildapi.GitSourceRevision{
Commit: "1234",
},
},
Strategy: strategy,
Output: output,
},
}
newBuild := generateBuildFromBuild(build)
if !reflect.DeepEqual(build.Parameters, newBuild.Parameters) {
t.Errorf("Build parameters does not match the original Build parameters")
}
if !reflect.DeepEqual(build.ObjectMeta.Labels, newBuild.ObjectMeta.Labels) {
t.Errorf("Build labels does not match the original Build labels")
}
}
func TestGetNextBuildName(t *testing.T) {
bc := mocks.MockBuildConfig(mocks.MockSource(), mocks.MockSourceStrategyForImageRepository(), mocks.MockOutput())
if expected, actual := bc.Name+"-1", getNextBuildName(bc); expected != actual {
t.Errorf("Wrong buildName, expected %s, got %s", expected, actual)
}
if expected, actual := 1, bc.LastVersion; expected != actual {
t.Errorf("Wrong version, expected %d, got %d", expected, actual)
}
}
func TestSubstituteImageCustomAllMismatch(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForDockerImage(originalImage)
output := mocks.MockOutput()
bc := mocks.MockBuildConfig(source, strategy, output)
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
// Full custom build with base image that is not matched
// Base image name should be unchanged
updateCustomImageEnv(build.Parameters.Strategy.CustomStrategy, "dummy")
if build.Parameters.Strategy.CustomStrategy.From.Name != originalImage {
t.Errorf("Base image name was improperly substituted in custom strategy %s %s", build.Parameters.Strategy.CustomStrategy.From.Name, originalImage)
}
}
func TestGenerateBuildFromConfigWithSecrets(t *testing.T) {
source := mocks.MockSource()
revision := &buildapi.SourceRevision{
Type: buildapi.BuildSourceGit,
Git: &buildapi.GitSourceRevision{
Commit: "abcd",
},
}
dockerCfgTable := map[string]map[string][]byte{
// FIXME: This image pull spec does not return ANY registry, but it should
// return the hub.
//"docker.io/secret2/image": {".dockercfg": sampleDockerConfigs["hub"]},
"secret1/image": {".dockercfg": mocks.SampleDockerConfigs["hub"]},
"1.1.1.1:5000/secret3/image": {".dockercfg": mocks.SampleDockerConfigs["ipv4"]},
"registry.host/secret4/image": {".dockercfg": mocks.SampleDockerConfigs["host"]},
}
for imageName := range dockerCfgTable {
// Setup the BuildGenerator
strategy := mockDockerStrategyForDockerImage(imageName)
output := mockOutputWithImageName(imageName)
generator := mockBuildGenerator()
bc := mocks.MockBuildConfig(source, strategy, output)
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, revision)
if build.Parameters.Output.PushSecret == nil {
t.Errorf("Expected PushSecret for image '%s' to be set, got nil", imageName)
continue
}
if build.Parameters.Strategy.DockerStrategy.PullSecret == nil {
t.Errorf("Expected PullSecret for image '%s' to be set, got nil", imageName)
continue
}
if len(build.Parameters.Output.PushSecret.Name) == 0 {
t.Errorf("Expected PushSecret for image %s to be set not empty", imageName)
}
if len(build.Parameters.Strategy.DockerStrategy.PullSecret.Name) == 0 {
t.Errorf("Expected PullSecret for image %s to be set not empty", imageName)
}
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
}
}
func TestSubstituteImageCustomBaseMatchEnvNil(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForImageRepository()
output := mocks.MockOutput()
bc := mocks.MockBuildConfig(source, strategy, output)
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
// Custom build with a base Image but no environment variables
// base image should be replaced, new image environment variable should be added
updateCustomImageEnv(build.Parameters.Strategy.CustomStrategy, newImage)
if build.Parameters.Strategy.CustomStrategy.Env[0].Name != buildapi.CustomBuildStrategyBaseImageKey || build.Parameters.Strategy.CustomStrategy.Env[0].Value != newImage {
t.Errorf("New image name variable was not added to environment list in custom strategy")
}
if c := len(build.Parameters.Strategy.CustomStrategy.Env); c != 1 {
t.Errorf("Expected %d, found %d environment variables", 1, c)
}
}
func TestCreateInstantiate(t *testing.T) {
imageStream := mocks.MockImageStream("testImageStream", "registry.com/namespace/imagename", map[string]string{"test": "newImageID123"})
image := mocks.MockImage("testImage@id", "registry.com/namespace/imagename@id")
fakeSecrets := []runtime.Object{}
for _, s := range mocks.MockBuilderSecrets() {
fakeSecrets = append(fakeSecrets, s)
}
rest := InstantiateREST{&generator.BuildGenerator{
Secrets: testclient.NewSimpleFake(fakeSecrets...),
ServiceAccounts: mocks.MockBuilderServiceAccount(mocks.MockBuilderSecrets()),
Client: generator.Client{
GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
return mocks.MockBuildConfig(mocks.MockSource(), mocks.MockSourceStrategyForImageRepository(), mocks.MockOutput()), nil
},
UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
return nil
},
CreateBuildFunc: func(ctx kapi.Context, build *buildapi.Build) error {
return nil
},
GetBuildFunc: func(ctx kapi.Context, name string) (*buildapi.Build, error) {
return &buildapi.Build{}, nil
},
GetImageStreamFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStream, error) {
return imageStream, nil
},
GetImageStreamTagFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamTag, error) {
return &imageapi.ImageStreamTag{Image: *image}, nil
},
GetImageStreamImageFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamImage, error) {
return &imageapi.ImageStreamImage{Image: *image}, nil
},
}}}
_, err := rest.Create(kapi.NewDefaultContext(), &buildapi.BuildRequest{ObjectMeta: kapi.ObjectMeta{Name: "name"}})
if err != nil {
t.Errorf("Unexpected error %v", err)
}
}
func mockBuildGenerator() *BuildGenerator {
fakeSecrets := []runtime.Object{}
for _, s := range mocks.MockBuilderSecrets() {
fakeSecrets = append(fakeSecrets, s)
}
return &BuildGenerator{
Secrets: testclient.NewSimpleFake(fakeSecrets...),
ServiceAccounts: mocks.MockBuilderServiceAccount(mocks.MockBuilderSecrets()),
Client: Client{
GetBuildConfigFunc: func(ctx kapi.Context, name string) (*buildapi.BuildConfig, error) {
return mocks.MockBuildConfig(mocks.MockSource(), mocks.MockSourceStrategyForImageRepository(), mocks.MockOutput()), nil
},
UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
return nil
},
CreateBuildFunc: func(ctx kapi.Context, build *buildapi.Build) error {
return nil
},
GetBuildFunc: func(ctx kapi.Context, name string) (*buildapi.Build, error) {
return &buildapi.Build{}, nil
},
GetImageStreamFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStream, error) {
if name != imageRepoName {
return &imageapi.ImageStream{}, nil
}
return &imageapi.ImageStream{
ObjectMeta: kapi.ObjectMeta{
Name: imageRepoName,
Namespace: imageRepoNamespace,
},
Status: imageapi.ImageStreamStatus{
DockerImageRepository: "repo/namespace/image",
Tags: map[string]imageapi.TagEventList{
tagName: {
Items: []imageapi.TagEvent{
{DockerImageReference: dockerReference},
},
},
imageapi.DefaultImageTag: {
Items: []imageapi.TagEvent{
{DockerImageReference: latestDockerReference},
},
},
},
},
}, nil
},
GetImageStreamTagFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamTag, error) {
return &imageapi.ImageStreamTag{
Image: imageapi.Image{
ObjectMeta: kapi.ObjectMeta{Name: imageRepoName + ":" + newTag},
DockerImageReference: latestDockerReference,
},
}, nil
},
GetImageStreamImageFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamImage, error) {
return &imageapi.ImageStreamImage{
Image: imageapi.Image{
ObjectMeta: kapi.ObjectMeta{Name: imageRepoName + ":@id"},
DockerImageReference: latestDockerReference,
},
}, nil
},
}}
}
func TestGenerateBuildWithImageTagForCustomStrategyImageRepository(t *testing.T) {
source := mocks.MockSource()
strategy := mockCustomStrategyForImageRepository()
output := mocks.MockOutput()
bc := &buildapi.BuildConfig{
ObjectMeta: kapi.ObjectMeta{
Name: "test-build-config",
},
Parameters: buildapi.BuildParameters{
Source: source,
Revision: &buildapi.SourceRevision{
Type: buildapi.BuildSourceGit,
Git: &buildapi.GitSourceRevision{
Commit: "1234",
},
},
Strategy: strategy,
Output: output,
},
}
fakeSecrets := []runtime.Object{}
for _, s := range mocks.MockBuilderSecrets() {
fakeSecrets = append(fakeSecrets, s)
}
generator := BuildGenerator{
Secrets: testclient.NewSimpleFake(fakeSecrets...),
ServiceAccounts: mocks.MockBuilderServiceAccount(mocks.MockBuilderSecrets()),
Client: Client{
GetImageStreamFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStream, error) {
return &imageapi.ImageStream{
ObjectMeta: kapi.ObjectMeta{Name: imageRepoName},
Status: imageapi.ImageStreamStatus{
DockerImageRepository: originalImage,
Tags: map[string]imageapi.TagEventList{
tagName: {
Items: []imageapi.TagEvent{
{
DockerImageReference: fmt.Sprintf("%s:%s", originalImage, newTag),
Image: newTag,
},
},
},
},
},
}, nil
},
GetImageStreamTagFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamTag, error) {
return &imageapi.ImageStreamTag{
Image: imageapi.Image{
ObjectMeta: kapi.ObjectMeta{Name: imageRepoName + ":" + newTag},
DockerImageReference: originalImage + ":" + newTag,
},
}, nil
},
GetImageStreamImageFunc: func(ctx kapi.Context, name string) (*imageapi.ImageStreamImage, error) {
return &imageapi.ImageStreamImage{
Image: imageapi.Image{
ObjectMeta: kapi.ObjectMeta{Name: imageRepoName + ":@id"},
DockerImageReference: originalImage + ":" + newTag,
},
}, nil
},
UpdateBuildConfigFunc: func(ctx kapi.Context, buildConfig *buildapi.BuildConfig) error {
return nil
},
}}
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, nil)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
if build.Parameters.Strategy.CustomStrategy.From.Name != newImage {
t.Errorf("Custom base image value %s does not match expected value %s", build.Parameters.Strategy.CustomStrategy.From.Name, newImage)
}
}
func TestGenerateBuildFromConfig(t *testing.T) {
source := mocks.MockSource()
strategy := mockDockerStrategyForDockerImage(originalImage)
output := mocks.MockOutput()
resources := mockResources()
bc := &buildapi.BuildConfig{
ObjectMeta: kapi.ObjectMeta{
Name: "test-build-config",
Namespace: "test-namespace",
Labels: map[string]string{"testlabel": "testvalue"},
},
Parameters: buildapi.BuildParameters{
Source: source,
Revision: &buildapi.SourceRevision{
Type: buildapi.BuildSourceGit,
Git: &buildapi.GitSourceRevision{
Commit: "1234",
},
},
Strategy: strategy,
Output: output,
Resources: resources,
},
}
revision := &buildapi.SourceRevision{
Type: buildapi.BuildSourceGit,
Git: &buildapi.GitSourceRevision{
Commit: "abcd",
},
}
generator := mockBuildGenerator()
build, err := generator.generateBuildFromConfig(kapi.NewContext(), bc, revision)
if err != nil {
t.Fatalf("Unexpected error %v", err)
}
if !reflect.DeepEqual(source, build.Parameters.Source) {
t.Errorf("Build source does not match BuildConfig source")
}
// FIXME: This is disabled because the strategies does not match since we plug the
// pullSecret into the build strategy.
/*
if !reflect.DeepEqual(strategy, build.Parameters.Strategy) {
t.Errorf("Build strategy does not match BuildConfig strategy %+v != %+v", strategy.DockerStrategy, build.Parameters.Strategy.DockerStrategy)
}
*/
if !reflect.DeepEqual(output, build.Parameters.Output) {
t.Errorf("Build output does not match BuildConfig output")
}
if !reflect.DeepEqual(revision, build.Parameters.Revision) {
t.Errorf("Build revision does not match passed in revision")
}
if !reflect.DeepEqual(resources, build.Parameters.Resources) {
t.Errorf("Build resources does not match passed in resources")
}
if build.Labels["testlabel"] != bc.Labels["testlabel"] {
t.Errorf("Build does not contain labels from BuildConfig")
}
if build.Labels[buildapi.BuildConfigLabel] != bc.Name {
t.Errorf("Build does not contain labels from BuildConfig")
}
if build.Config.Name != bc.Name || build.Config.Namespace != bc.Namespace || build.Config.Kind != "BuildConfig" {
t.Errorf("Build does not contain correct BuildConfig reference: %v", build.Config)
}
}