func handleDataDownReply(ctx Context, rxPacket models.RXPacket, ns models.NodeSession) error { macPL, ok := rxPacket.PHYPayload.MACPayload.(*lorawan.MACPayload) if !ok { return fmt.Errorf("expected *lorawan.MACPayload, got: %T", rxPacket.PHYPayload.MACPayload) } // get data down properies properties, err := getDataDownProperties(rxPacket.RXInfo, ns) if err != nil { return fmt.Errorf("get data down properties error: %s", err) } var frmMACCommands bool var macPayloads []models.MACPayload allMACPayloads, err := storage.ReadMACPayloadTXQueue(ctx.RedisPool, ns.DevAddr) if err != nil { return fmt.Errorf("read mac-payload tx queue error: %s", err) } if len(allMACPayloads) > 0 { if allMACPayloads[0].FRMPayload { // the first mac-commands must be sent as FRMPayload, filter the rest // of the MACPayload items with the same property, respecting the // max FRMPayload size for the data-rate. frmMACCommands = true macPayloads = storage.FilterMACPayloads(allMACPayloads, true, common.Band.MaxPayloadSize[properties.rx1DR].N) } else { // the first mac-command must be sent as FOpts, filter the rest of // the MACPayload items with the same property, respecting the // max FOpts size of 15. macPayloads = storage.FilterMACPayloads(allMACPayloads, false, 15) } } // if the MACCommands (if any) are not sent as FRMPayload, check if there // is a tx-payload in the queue and validate if the FOpts + FRMPayload // does not exceed the max payload size. var txPayload *models.TXPayload if !frmMACCommands { // check if there are payloads pending in the queue txPayload, err = getNextValidTXPayloadForDRFromQueue(ctx, ns, properties.rx1DR) if err != nil { return fmt.Errorf("get next valid tx-payload error: %s", err) } var macByteCount int for _, mac := range macPayloads { macByteCount += len(mac.MACCommand) } if txPayload != nil && len(txPayload.Data)+macByteCount > common.Band.MaxPayloadSize[properties.rx1DR].N { log.WithFields(log.Fields{ "data_rate": properties.rx1DR, "dev_eui": ns.DevEUI, "reference": txPayload.Reference, }).Info("scheduling tx-payload for next downlink, mac-commands + payload exceeds max size") txPayload = nil } } // convert the MACPayload items into MACCommand items var macCommmands []lorawan.MACCommand for _, pl := range macPayloads { var mac lorawan.MACCommand if err := mac.UnmarshalBinary(false, pl.MACCommand); err != nil { // in case the mac commands can't be unmarshaled, the payload // is ignored and an error sent to the network-controller errStr := fmt.Sprintf("unmarshal mac command error: %s", err) log.WithFields(log.Fields{ "dev_eui": ns.DevEUI, "reference": pl.Reference, }).Warning(errStr) err = ctx.Controller.SendErrorPayload(ns.AppEUI, ns.DevEUI, models.ErrorPayload{ Reference: pl.Reference, DevEUI: ns.DevEUI, Message: errStr, }) if err != nil { return fmt.Errorf("send error payload to network-controller error: %s", err) } continue } macCommmands = append(macCommmands, mac) } // uplink was unconfirmed and no downlink data in queue and no mac commands to send if txPayload == nil && rxPacket.PHYPayload.MHDR.MType == lorawan.UnconfirmedDataUp && len(macCommmands) == 0 { return nil } // get the queue size (the size includes the current payload) queueSize, err := storage.GetTXPayloadQueueSize(ctx.RedisPool, ns.DevEUI) if err != nil { return err } if txPayload != nil { queueSize-- // substract the current tx-payload from the queue-size } phy := lorawan.PHYPayload{ MHDR: lorawan.MHDR{ MType: lorawan.UnconfirmedDataDown, Major: lorawan.LoRaWANR1, }, } macPL = &lorawan.MACPayload{ FHDR: lorawan.FHDR{ DevAddr: ns.DevAddr, FCtrl: lorawan.FCtrl{ ACK: rxPacket.PHYPayload.MHDR.MType == lorawan.ConfirmedDataUp, // set ACK when uplink packet was of type ConfirmedDataUp FPending: queueSize > 0 || len(allMACPayloads) != len(macPayloads), // items in the queue or not all mac commands being sent }, FCnt: ns.FCntDown, }, } phy.MACPayload = macPL if len(macCommmands) > 0 { if frmMACCommands { var fPort uint8 // 0 var frmPayload []lorawan.Payload for i := range macCommmands { frmPayload = append(frmPayload, &macCommmands[i]) } macPL.FPort = &fPort macPL.FRMPayload = frmPayload } else { macPL.FHDR.FOpts = macCommmands } } // add the payload to FRMPayload field // note that txPayload is by definition nil when there are mac commands // to send in the FRMPayload field. if txPayload != nil { if txPayload.Confirmed { phy.MHDR.MType = lorawan.ConfirmedDataDown } macPL.FPort = &txPayload.FPort macPL.FRMPayload = []lorawan.Payload{ &lorawan.DataPayload{Bytes: txPayload.Data}, } } // if there is no payload set, encrypt will just do nothing if len(macCommmands) > 0 && frmMACCommands { if err := phy.EncryptFRMPayload(ns.NwkSKey); err != nil { return fmt.Errorf("encrypt FRMPayload error: %s", err) } } else { if err := phy.EncryptFRMPayload(ns.AppSKey); err != nil { return fmt.Errorf("encrypt FRMPayload error: %s", err) } } if err := phy.SetMIC(ns.NwkSKey); err != nil { return fmt.Errorf("set MIC error: %s", err) } txPacket := models.TXPacket{ TXInfo: models.TXInfo{ MAC: rxPacket.RXInfo.MAC, Timestamp: rxPacket.RXInfo.Timestamp + uint32(properties.rxDelay/time.Microsecond), Frequency: properties.rx1Frequency, Power: common.Band.DefaultTXPower, DataRate: common.Band.DataRates[properties.rx1DR], CodeRate: rxPacket.RXInfo.CodeRate, }, PHYPayload: phy, } // window 1 if err := ctx.Gateway.SendTXPacket(txPacket); err != nil { return fmt.Errorf("send tx packet (rx window 1) to gateway error: %s", err) } // increment the FCntDown when MType != ConfirmedDataDown and clear // in-process queue. In case of ConfirmedDataDown we increment on ACK. if phy.MHDR.MType != lorawan.ConfirmedDataDown { ns.FCntDown++ if err = storage.SaveNodeSession(ctx.RedisPool, ns); err != nil { return err } if txPayload != nil { if _, err = storage.ClearInProcessTXPayload(ctx.RedisPool, ns.DevEUI); err != nil { return err } } } // remove the mac commands from the queue for _, pl := range macPayloads { if err = storage.DeleteMACPayloadFromTXQueue(ctx.RedisPool, ns.DevAddr, pl); err != nil { return fmt.Errorf("delete mac-payload from tx queue error: %s", err) } } return nil }
func TestNodeAPI(t *testing.T) { conf := common.GetTestConfig() Convey("Given a clean database with an application and api instance", t, func() { db, err := storage.OpenDatabase(conf.PostgresDSN) So(err, ShouldBeNil) common.MustResetDB(db) p := storage.NewRedisPool(conf.RedisURL) common.MustFlushRedis(p) ctx := context.Background() lsCtx := loraserver.Context{DB: db, RedisPool: p} api := NewNodeAPI(lsCtx) app := models.Application{ AppEUI: [8]byte{1, 2, 3, 4, 5, 6, 7, 8}, Name: "test app", } So(storage.CreateApplication(db, app), ShouldBeNil) Convey("When creating a node", func() { _, err := api.Create(ctx, &pb.CreateNodeRequest{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "01020304050607080102030405060708", RxDelay: 1, Rx1DROffset: 3, }) So(err, ShouldBeNil) Convey("The node has been created", func() { node, err := api.Get(ctx, &pb.GetNodeRequest{DevEUI: "0807060504030201"}) So(err, ShouldBeNil) So(node, ShouldResemble, &pb.GetNodeResponse{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "01020304050607080102030405060708", RxDelay: 1, Rx1DROffset: 3, }) }) Convey("Then listing the nodes returns a single items", func() { nodes, err := api.List(ctx, &pb.ListNodeRequest{ Limit: 10, }) So(err, ShouldBeNil) So(nodes.Result, ShouldHaveLength, 1) So(nodes.TotalCount, ShouldEqual, 1) So(nodes.Result[0], ShouldResemble, &pb.GetNodeResponse{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "01020304050607080102030405060708", RxDelay: 1, Rx1DROffset: 3, }) }) Convey("Then listing the nodes for a given AppEUI returns a single item", func() { nodes, err := api.ListByAppEUI(ctx, &pb.ListNodeByAppEUIRequest{ Limit: 10, AppEUI: "0102030405060708", }) So(err, ShouldBeNil) So(nodes.Result, ShouldHaveLength, 1) So(nodes.TotalCount, ShouldEqual, 1) So(nodes.Result[0], ShouldResemble, &pb.GetNodeResponse{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "01020304050607080102030405060708", RxDelay: 1, Rx1DROffset: 3, }) }) Convey("When updating the node", func() { _, err := api.Update(ctx, &pb.UpdateNodeRequest{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "08070605040302010807060504030201", RxDelay: 3, Rx1DROffset: 1, }) So(err, ShouldBeNil) Convey("Then the node has been updated", func() { node, err := api.Get(ctx, &pb.GetNodeRequest{DevEUI: "0807060504030201"}) So(err, ShouldBeNil) So(node, ShouldResemble, &pb.GetNodeResponse{ DevEUI: "0807060504030201", AppEUI: "0102030405060708", AppKey: "08070605040302010807060504030201", RxDelay: 3, Rx1DROffset: 1, }) }) }) Convey("After deleting the node", func() { _, err := api.Delete(ctx, &pb.DeleteNodeRequest{DevEUI: "0807060504030201"}) So(err, ShouldBeNil) Convey("Then listing the nodes returns zero nodes", func() { nodes, err := api.List(ctx, &pb.ListNodeRequest{Limit: 10}) So(err, ShouldBeNil) So(nodes.TotalCount, ShouldEqual, 0) So(nodes.Result, ShouldHaveLength, 0) }) }) Convey("Given a tx payload in the the queue", func() { So(storage.AddTXPayloadToQueue(p, models.TXPayload{ DevEUI: [8]byte{8, 7, 6, 5, 4, 3, 2, 1}, Data: []byte("hello!"), }), ShouldBeNil) count, err := storage.GetTXPayloadQueueSize(p, [8]byte{8, 7, 6, 5, 4, 3, 2, 1}) So(err, ShouldBeNil) So(count, ShouldEqual, 1) Convey("When flushing the tx-payload queue", func() { _, err := api.FlushTXPayloadQueue(ctx, &pb.FlushTXPayloadQueueRequest{DevEUI: "0807060504030201"}) So(err, ShouldBeNil) Convey("Then the queue is empty", func() { count, err := storage.GetTXPayloadQueueSize(p, [8]byte{8, 7, 6, 5, 4, 3, 2, 1}) So(err, ShouldBeNil) So(count, ShouldEqual, 0) }) }) }) }) }) }