// GetCurrent returns the current, open code review. // // If there are multiple matching reviews, then an error is returned. func GetCurrent(repo repository.Repo) (*Review, error) { reviewRef := repo.GetHeadRef() var matchingReviews []Review for _, review := range ListOpen(repo) { if review.Request.ReviewRef == reviewRef { matchingReviews = append(matchingReviews, review) } } if matchingReviews == nil { return nil, nil } if len(matchingReviews) != 1 { return nil, fmt.Errorf("There are %d open reviews for the ref \"%s\"", len(matchingReviews), reviewRef) } r := &matchingReviews[0] return r, nil }
// GetCurrent returns the current, open code review. // // If there are multiple matching reviews, then an error is returned. func GetCurrent(repo repository.Repo) (*Review, error) { reviewRef, err := repo.GetHeadRef() if err != nil { return nil, err } var matchingReviews []Summary for _, review := range ListOpen(repo) { if review.Request.ReviewRef == reviewRef { matchingReviews = append(matchingReviews, review) } } if matchingReviews == nil { return nil, nil } if len(matchingReviews) != 1 { return nil, fmt.Errorf("There are %d open reviews for the ref \"%s\"", len(matchingReviews), reviewRef) } return matchingReviews[0].Details() }
// GetCurrent returns the current, open code review. // // If there are multiple matching reviews, then an error is returned. func GetCurrent(repo repository.Repo) (*Review, error) { reviewRef := repo.GetHeadRef() currentCommit := repo.GetCommitHash(reviewRef) var matchingReviews []Review for _, review := range ListOpen(repo) { if review.Request.ReviewRef == reviewRef { matchingReviews = append(matchingReviews, review) } } if matchingReviews == nil { return nil, nil } if len(matchingReviews) != 1 { return nil, fmt.Errorf("There are %d open reviews for the ref \"%s\"", len(matchingReviews), reviewRef) } r := &matchingReviews[0] reports := ci.ParseAllValid(repo.GetNotes(ci.Ref, currentCommit)) r.Reports = reports return r, nil }
// Create a new code review request. // // The "args" parameter is all of the command line arguments that followed the subcommand. func requestReview(repo repository.Repo, args []string) error { requestFlagSet.Parse(args) if !*requestAllowUncommitted { // Requesting a code review with uncommited local changes is usually a mistake, so // we want to report that to the user instead of creating the request. if repo.HasUncommittedChanges() { return errors.New("You have uncommitted or untracked files. Use --allow-uncommitted to ignore those.") } } r := buildRequestFromFlags(repo.GetUserEmail()) if r.ReviewRef == "HEAD" { r.ReviewRef = repo.GetHeadRef() } repo.VerifyGitRefOrDie(r.TargetRef) repo.VerifyGitRefOrDie(r.ReviewRef) r.BaseCommit = repo.GetCommitHash(r.TargetRef) reviewCommits := repo.ListCommitsBetween(r.TargetRef, r.ReviewRef) if reviewCommits == nil { return errors.New("There are no commits included in the review request") } if r.Description == "" { r.Description = repo.GetCommitMessage(reviewCommits[0]) } note, err := r.Write() if err != nil { return err } repo.AppendNote(request.Ref, reviewCommits[0], note) if !*requestQuiet { fmt.Printf(requestSummaryTemplate, reviewCommits[0], r.TargetRef, r.ReviewRef, r.Description) } return nil }
// Create a new code review request. // // The "args" parameter is all of the command line arguments that followed the subcommand. func requestReview(repo repository.Repo, args []string) error { requestFlagSet.Parse(args) args = requestFlagSet.Args() if !*requestAllowUncommitted { // Requesting a code review with uncommited local changes is usually a mistake, so // we want to report that to the user instead of creating the request. hasUncommitted, err := repo.HasUncommittedChanges() if err != nil { return err } if hasUncommitted { return errors.New("You have uncommitted or untracked files. Use --allow-uncommitted to ignore those.") } } userEmail, err := repo.GetUserEmail() if err != nil { return err } r, err := buildRequestFromFlags(userEmail) if err != nil { return err } if r.ReviewRef == "HEAD" { headRef, err := repo.GetHeadRef() if err != nil { return err } r.ReviewRef = headRef } if err := repo.VerifyGitRef(r.TargetRef); err != nil { return err } if err := repo.VerifyGitRef(r.ReviewRef); err != nil { return err } reviewCommit, baseCommit, err := getReviewCommit(repo, r, args) if err != nil { return err } r.BaseCommit = baseCommit if r.Description == "" { description, err := repo.GetCommitMessage(reviewCommit) if err != nil { return err } r.Description = description } note, err := r.Write() if err != nil { return err } repo.AppendNote(request.Ref, reviewCommit, note) if !*requestQuiet { fmt.Printf(requestSummaryTemplate, reviewCommit, r.TargetRef, r.ReviewRef, r.Description) } return nil }