func (u *FeedUpdater) RefreshFeed(staleFeed data.Feed) { rawFeed, err := u.fetchFeed(staleFeed.URL.Value, staleFeed.ETag) if err != nil { u.logger.Error("fetchFeed failed", "url", staleFeed.URL.Value, "error", err) data.UpdateFeedWithFetchFailure(u.pool, staleFeed.ID.Value, err.Error(), time.Now()) return } // 304 unchanged if rawFeed == nil { u.logger.Info("fetchFeed 304 unchanged", "url", staleFeed.URL.Value) data.UpdateFeedWithFetchUnchanged(u.pool, staleFeed.ID.Value, time.Now()) return } feed, err := parseFeed(rawFeed.body) if err != nil { u.logger.Error("parseFeed failed", "url", staleFeed.URL.Value, "error", err) data.UpdateFeedWithFetchFailure(u.pool, staleFeed.ID.Value, fmt.Sprintf("Unable to parse feed: %v", err), time.Now()) return } u.logger.Info("refreshFeed succeeded", "url", staleFeed.URL.Value, "id", staleFeed.ID.Value) data.UpdateFeedWithFetchSuccess(u.pool, staleFeed.ID.Value, feed, rawFeed.etag, time.Now()) }
func TestDataFeeds(t *testing.T) { pool := newConnPool(t) userID, err := data.CreateUser(pool, newUser()) if err != nil { t.Fatal(err) } now := time.Now() fiveMinutesAgo := now.Add(-5 * time.Minute) tenMinutesAgo := now.Add(-10 * time.Minute) fifteenMinutesAgo := now.Add(-15 * time.Minute) update := &data.ParsedFeed{Name: "baz", Items: make([]data.ParsedItem, 0)} // Create a feed url := "http://bar" err = data.InsertSubscription(pool, userID, url) if err != nil { t.Fatal(err) } // A new feed has never been fetched -- it should need fetching staleFeeds, err := data.GetFeedsUncheckedSince(pool, tenMinutesAgo) if err != nil { t.Fatal(err) } if len(staleFeeds) != 1 { t.Fatalf("Found %d stale feed, expected 1", len(staleFeeds)) } if staleFeeds[0].URL.Value != url { t.Errorf("Expected %v, got %v", url, staleFeeds[0].URL) } feedID := staleFeeds[0].ID.Value nullString := data.String{Status: data.Null} // Update feed as of now err = data.UpdateFeedWithFetchSuccess(pool, feedID, update, nullString, now) if err != nil { t.Fatal(err) } // feed should no longer be stale staleFeeds, err = data.GetFeedsUncheckedSince(pool, tenMinutesAgo) if err != nil { t.Fatal(err) } if len(staleFeeds) != 0 { t.Fatalf("Found %d stale feed, expected 0", len(staleFeeds)) } // Update feed to be old enough to need refresh err = data.UpdateFeedWithFetchSuccess(pool, feedID, update, nullString, fifteenMinutesAgo) if err != nil { t.Fatal(err) } // It should now need fetching staleFeeds, err = data.GetFeedsUncheckedSince(pool, tenMinutesAgo) if err != nil { t.Fatal(err) } if len(staleFeeds) != 1 { t.Fatalf("Found %d stale feed, expected 1", len(staleFeeds)) } if staleFeeds[0].ID.Value != feedID { t.Errorf("Expected %v, got %v", feedID, staleFeeds[0].ID) } // But update feed with a recent failed fetch err = data.UpdateFeedWithFetchFailure(pool, feedID, "something went wrong", fiveMinutesAgo) if err != nil { t.Fatal(err) } // feed should no longer be stale staleFeeds, err = data.GetFeedsUncheckedSince(pool, tenMinutesAgo) if err != nil { t.Fatal(err) } if len(staleFeeds) != 0 { t.Fatalf("Found %d stale feed, expected 0", len(staleFeeds)) } }